Tests fail with new oslo.utils 1.2.1

Bug #1408838 reported by Jamie Lennox
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystonemiddleware
Fix Released
Medium
Jamie Lennox
Juno
Fix Released
Medium
Jamie Lennox
python-keystoneclient
Fix Released
Medium
Jamie Lennox

Bug Description

With the move to oslo namespace packages the mocks we use in the auth_token tests no longer work as the path has changed.

The timeutils provides it's own set_time_override mock and we should use that instead of mocking functions directly.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/145981

Changed in python-keystoneclient:
assignee: nobody → Jamie Lennox (jamielennox)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystonemiddleware (master)

Fix proposed to branch: master
Review: https://review.openstack.org/145989

Changed in keystonemiddleware:
assignee: nobody → Jamie Lennox (jamielennox)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystonemiddleware (master)

Reviewed: https://review.openstack.org/145989
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=a4a46764491aa36ec4440c91c435578e178f14f8
Submitter: Jenkins
Branch: master

commit a4a46764491aa36ec4440c91c435578e178f14f8
Author: Jamie Lennox <email address hidden>
Date: Fri Jan 9 10:57:13 2015 +1000

    Use a test fixture for mocking time

    Use a fixture and the mocking functions provided in oslo.utils.timeutils
    rather than mocking the function directly. This broke when the functions
    moved.

    Change-Id: I65b6ae58c6b4e02e235f992c21502aa377992985
    Closes-Bug: #1408838

Changed in keystonemiddleware:
status: In Progress → Fix Committed
Changed in python-keystoneclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/145981
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=a51d899d20fbcbd7c7c91ab785056ad0d251e946
Submitter: Jenkins
Branch: master

commit a51d899d20fbcbd7c7c91ab785056ad0d251e946
Author: Jamie Lennox <email address hidden>
Date: Fri Jan 9 10:24:08 2015 +1000

    Use a test fixture for mocking time

    Use a fixture and the mocking functions provided in oslo.utils.timeutils
    rather than mocking the function directly. This broke when the functions
    moved.

    Change-Id: I431cff8bdb9d80fe17a061f482209b658e158723
    Closes-Bug: #1408838

Changed in python-keystoneclient:
milestone: none → 1.1.0
Changed in keystonemiddleware:
milestone: none → 1.4.0
importance: Undecided → Medium
Changed in python-keystoneclient:
importance: Undecided → Medium
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
Changed in keystonemiddleware:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystonemiddleware (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/175232

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystonemiddleware (stable/juno)

Reviewed: https://review.openstack.org/175232
Committed: https://git.openstack.org/cgit/openstack/keystonemiddleware/commit/?id=62208d6a9ac067b2329b0e655fe529d1f62e32b6
Submitter: Jenkins
Branch: stable/juno

commit 62208d6a9ac067b2329b0e655fe529d1f62e32b6
Author: Jamie Lennox <email address hidden>
Date: Fri Jan 9 10:57:13 2015 +1000

    Use a test fixture for mocking time

    Use a fixture and the mocking functions provided in oslo.utils.timeutils
    rather than mocking the function directly. This broke when the functions
    moved.

    Change-Id: I65b6ae58c6b4e02e235f992c21502aa377992985
    Closes-Bug: #1408838
    (cherry picked from commit a4a46764491aa36ec4440c91c435578e178f14f8)

tags: added: in-stable-juno
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.