reattaching volumes fail with LIO Target Objects

[Tomoki Sekiyama]

In LVM iSCSI driver with 'iscsi_helper = lioadm' (after transition to Target Objects), reattaching a volume to a nova instance will fail with exception.

$ nova volume-attach c1 985a4376-ad0d-4287-a404-cdcbb19f52f1
  ( => succeeds)
$ nova volume-detach c1 985a4376-ad0d-4287-a404-cdcbb19f52f1
  ( => succeeds)
$ nova volume-attach c1 985a4376-ad0d-4287-a404-cdcbb19f52f1
  ( => fails with exception in cinder-volume)

LOG:

2015-01-07 15:28:10.947 ERROR cinder.volume.targets.lio [req-c58d38a2-5441-434b-842b-3602ded04314 e2ed9eef
c3ed4ffe86d50676c8dd35b4 c63e202b047c4c4188ea52485361f38b] Failed to add initiator iqn iqn.1994-05.com.red
hat:cafa39879ee to target
2015-01-07 15:28:10.948 ERROR cinder.volume.manager [req-c58d38a2-5441-434b-842b-3602ded04314 e2ed9eefc3ed
4ffe86d50676c8dd35b4 c63e202b047c4c4188ea52485361f38b] Unable to fetch connection information from backend
: Failed to attach iSCSI target for volume 985a4376-ad0d-4287-a404-cdcbb19f52f1.
2015-01-07 15:28:10.950 INFO cinder.volume.targets.lio [req-c58d38a2-5441-434b-842b-3602ded04314 e2ed9eefc
3ed4ffe86d50676c8dd35b4 c63e202b047c4c4188ea52485361f38b] Skipping remove_export. No iscsi_target provisio
ned for volume: 985a4376-ad0d-4287-a404-cdcbb19f52f1
2015-01-07 15:28:10.951 ERROR oslo.messaging.rpc.dispatcher [req-c58d38a2-5441-434b-842b-3602ded04314 e2ed
9eefc3ed4ffe86d50676c8dd35b4 c63e202b047c4c4188ea52485361f38b] Exception during message handling: Bad or u
nexpected response from the storage volume backend API: Unable to fetch connection information from backend: Failed to attach iSCSI target for volume 985a4376-ad0d-4287-a404-cdcbb19f52f1.
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher Traceback (most recent call last):
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher File "/usr/lib/python2.7/site-packages/oslo/messaging/rpc/dispatcher.py", line 137, in _dispatch_and_reply
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher incoming.message))
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher File "/usr/lib/python2.7/site-packages/oslo/messaging/rpc/dispatcher.py", line 180, in _dispatch
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher return self._do_dispatch(endpoint, method, ctxt, args)
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher File "/usr/lib/python2.7/site-packages/oslo/messaging/rpc/dispatcher.py", line 126, in _do_dispatch
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher result = getattr(endpoint, method)(ctxt, **new_args)
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher File "/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 105, in wrapper
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher return f(*args, **kwargs)
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 927, in initialize_connection
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher raise exception.VolumeBackendAPIException(data=err_msg)
2015-01-07 15:28:10.951 TRACE oslo.messaging.rpc.dispatcher VolumeBackendAPIException: Bad or unexpected response from the storage volume backend API: Unable to fetch connection information from backend: Failed to attach iSCSI target for volume 985a4376-ad0d-4287-a404-cdcbb19f52f1.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/145627

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/145628

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/145627
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=00b03b90cc460215c2e9f2aac107e362955320e2
Submitter: Jenkins
Branch: master

commit 00b03b90cc460215c2e9f2aac107e362955320e2
Author: Tomoki Sekiyama <email address hidden>
Date: Wed Jan 7 17:39:33 2015 -0500

    LVM: Add terminate_connection call for Target Objects

    terminate_connection should be redirected from LVM driver to targets
    object. Especially this is required in LioAdm to remove an initiator
    from a target. This also fixes some mismatch of method arguments and
    remove unused methods in target objects.

    Change-Id: Ic42836e995bbdaad92e355b94cb2d7b45d8fdb60
    Partial-Bug: #1408443

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/145628
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=65d9c20b453b7128b09c9069a69d2d520626f905
Submitter: Jenkins
Branch: master

commit 65d9c20b453b7128b09c9069a69d2d520626f905
Author: Tomoki Sekiyama <email address hidden>
Date: Wed Jan 7 17:33:51 2015 -0500

    cinder-rtstool: should use acl.node_wwn

    In newer version of rtslib module, NodeACL is now an object, not a
    dict. Thus, acl.node_wwn must be used instead of acl['node_wwn'],
    otherwise it will fail with exception.

    Change-Id: I0fb53596a2a99609aa4d573f1254b3afa7d9fd91
    Closes-Bug: #1408443