last.fm doesn't store failed submissions

Bug #140838 reported by themstpt
12
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Low
Dan O'Reilly

Bug Description

if there is a problem in the submission of played songs. it doesn't store that song and tries to submit later like the official last.fm client

Revision history for this message
themstpt (ric-alex-m-gmail) wrote :
Revision history for this message
Dan O'Reilly (oreilldf) wrote :

I wrote a patch that adds support for this. Odds are it's a little bit buggy, as last.fm is pretty particular about how things get submitted. Test it out and let me know if it works. Right now it adds the cache file in the ~/.exaile directory, Adam/Johannes, feel free to move or rename it however you think is appropriate. Improvements are welcomed as well (it was my first experience with xml, so I sort of winged most of the parsing stuff).

I also included a fix for another bug (https://bugs.launchpad.net/exaile/+bug/136000) with the patch, since it was applicable.

Revision history for this message
themstpt (ric-alex-m-gmail) wrote :

There was already a connection refused error..and the submission happened (it's a improvement because before the track wasn't submitted)

Revision history for this message
Adam Olsen (arolsen) wrote :

Committed in r1414

Changed in exaile:
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Dan O'Reilly (oreilldf) wrote :

Here's a patch to hopefully fix a crashing bug if there is no SCROBBLER_SESSION.

Revision history for this message
themstpt (ric-alex-m-gmail) wrote :

This bug is happening again in 2.11 :(

Changed in exaile:
status: Fix Committed → Confirmed
Revision history for this message
Dan O'Reilly (oreilldf) wrote :

That's because this patch isn't in 2.11. It probably won't be in a mainline release until 2.12 (or whatever the next version is).

Changed in exaile:
assignee: nobody → oreilldf
milestone: none → 0.2.12
status: Confirmed → Fix Committed
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.