Inconsistent detail page actions vs table row actions.

Bug #1408346 reported by Rob Cresswell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Unassigned

Bug Description

If you go to Admin > Port Details, amongst others, and click Edit in the top right, then you are shown the restricted edit view for a regular user, regardless of Admin privileges. I think these are generated in horizon/templates/horizon/common/_page_header.html

Steps to reproduce:
1. Go to Admin > Networks
2. Click a network name to view its ports
3. Click "Edit Port" (table row action), and view the available options
4. Close the edit modal, and click the port name to view its Detail page
5. Click "Edit Port" in the top right of the page. The options are different to that of the table action, but shouldn't be

The reverse appears to occur for instances. If you view Admin > Instances and click Edit Instance in the table, you are only shown the Information tab. If you click the name of the instance in the table, leading to the detail page, then hit Edit Instance, you can also edit Security Groups.

Steps to reproduce:
1. Go to Admin > Instances
2. Launch an instance, then click "Edit Instance" (table row action). You will see only the Information tab
3. Close the edit modal, and click the instance name to view its Detail page
4. In the dropdown in the top right, select "Edit Instance". The edit modal contains both Information and Security Groups configuration.

Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
description: updated
description: updated
Julie Pichon (jpichon)
Changed in horizon:
status: New → Confirmed
description: updated
description: updated
summary: - Inconsistent detail page Edit actions vs table Edit actions.
+ Inconsistent detail page actions vs table row actions.
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/146330

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/146330
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=49e40509eb7e14d084437ed78f1929efe4d39c46
Submitter: Jenkins
Branch: master

commit 49e40509eb7e14d084437ed78f1929efe4d39c46
Author: Rob Cresswell <email address hidden>
Date: Fri Jan 9 13:48:03 2015 +0000

    Fixes inconsistent Edit between tables & details

    This patch addresses several instances where clicking Edit on a Detail
    page (such as Edit Port on the Port Detail Page) gave either more or
    less options than the equivalent action in the Table. This patch fixes
    any occurences so that Edit ___ show the same form and fields regardless
    of where it is clicked

    Closes-bug: 1408346
    Change-Id: Ic2599d594b627bd7ab584d1a314360921e41a203

Changed in horizon:
status: In Progress → Fix Committed
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Low
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.