iscsi_write_cache option does not work by using LVM backend and TgtAdm/IserAdm

Bug #1408171 reported by Mitsuhiro Tanino
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
John Griffith

Bug Description

With LVM driver backend configured as 'iscsi_helper = tgtadm' or 'iscsi_helper = iseradm', iscsi_write_cache option does not work.

This option was introduced bug #1336568 to configure "write-cache" parameter of Tgtd. But after introducing commit 9651f547147188645942466602c92cce06666483, the option is ignored even if the parameter is configured in cinder.conf.

- Original Bug and Review
  https://bugs.launchpad.net/cinder/+bug/1336568
  https://review.openstack.org/#/c/104714/

Tags: drivers lvm
Changed in cinder:
assignee: nobody → Mitsuhiro Tanino (mitsuhiro-tanino)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/145415

Changed in cinder:
assignee: Mitsuhiro Tanino (mitsuhiro-tanino) → John Griffith (john-griffith)
status: New → In Progress
Changed in cinder:
importance: Undecided → Medium
Changed in cinder:
assignee: John Griffith (john-griffith) → Mitsuhiro Tanino (mitsuhiro-tanino)
Changed in cinder:
assignee: Mitsuhiro Tanino (mitsuhiro-tanino) → John Griffith (john-griffith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/145415
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=942981cdd3627c3ccd5dfe5db463f4ee2ccc73cb
Submitter: Jenkins
Branch: master

commit 942981cdd3627c3ccd5dfe5db463f4ee2ccc73cb
Author: John Griffith <email address hidden>
Date: Tue Jan 6 22:47:01 2015 -0700

    Fix iscsi_write_cache setting for iscsi targets

    While transitioning to the new driver and target
    model (change 9651f547147188645942466602c92cce06666483)
    some things got lost not surprisingly. One of those
    things that wasn't migrated correctly was the
    iscsi_write_cache option due to ensure_export not
    being called properly on service restart.

    This patch cleans up the ensure/create_export methods
    and their signatures. Most importantly esnure_export
    should now actually work and check the iscsi_write_cache
    settings.

    While fixing this I also cleaned up the two methods
    mentioned above to eliminate the unnecessary and
    duplicate info in their arguments.

    Closes-Bug: #1408171

    Change-Id: Ibfd1feefd72c43ef316b267e9d6645f2e67e2558

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to cinder (master)

Reviewed: https://review.openstack.org/145381
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=73363c1cacac15e8caee0df44db4a7dfdea9cc35
Submitter: Jenkins
Branch: master

commit 73363c1cacac15e8caee0df44db4a7dfdea9cc35
Author: Mitsuhiro Tanino <email address hidden>
Date: Fri Jan 9 20:11:43 2015 -0500

    Remove unused variables from ensure_export()

    After introducing commit 9651f547147188645942466602c92cce06666483,
    these three variables are obsolete in ensure_export().
    By remaining these variable, ensure_export() fails to export
    volumes after c-vol service is restart because the caller of
    ensure_export() in lvm driver does not pass these variables.

    - iscsi_name, volume_group, config

    Main clean up is done by commit Ibfd1feefd72c43ef316b267e9d6645f2e67e2558.
    This patch adds some tests for tgt, lio, and iser targets.
    And also adds initialization of chap_auth_userid and chap_auth_password
    in create_iscsi_target() because these variables might be referred
    before definition.

    Closes-bug: 1408121
    Related-bug: 1408171
    Change-Id: I8766eee33ae07fea71873809bfec37b8352c3a89

Thierry Carrez (ttx)
Changed in cinder:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.