Linux bridge agent should also handle empty before/after notifications properly

Bug #1407887 reported by KaiLin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Eugene Nikanorov

Bug Description

I am seeing the bug: https://bugs.launchpad.net/neutron/+bug/1367881
And it fixed the bug by handling empty before/after notifications in l2pop code.
Then I find there is the same problem in the method "_fdb_chg_ip" of linuxbridge_neutron_agent.

after = state.get('after')
                for mac, ip in after:
                    self.agent.br_mgr.add_fdb_ip_entry(mac, ip, interface)

 before = state.get('before')
                for mac, ip in before:
                    self.agent.br_mgr.remove_fdb_ip_entry(mac, ip, interface)

I think we should also change it.Otherwise, it may cause some similar problems.

Tags: linuxbridge
KaiLin (linkai3)
Changed in neutron:
assignee: nobody → KaiLin (linkai3)
Changed in neutron:
importance: Undecided → Low
status: New → Confirmed
tags: added: linuxbridge
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/166931

Changed in neutron:
assignee: KaiLin (linkai3) → Eugene Nikanorov (enikanorov)
status: Confirmed → In Progress
Changed in neutron:
milestone: none → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/166931
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cd4d2f03e83c326f849a0b18a666a406087c94e7
Submitter: Jenkins
Branch: master

commit cd4d2f03e83c326f849a0b18a666a406087c94e7
Author: Eugene Nikanorov <email address hidden>
Date: Mon Mar 23 07:51:06 2015 +0400

    Fix handling of before/after notifications in linuxbridge agent

    Avoid problem similar to described in bug #1367881

    Change-Id: I76059469c20be9161743ba730e46da1789ded4a8
    Closes-Bug: #1407887
    Related-Bug: #1367881

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.