Allow empty 'config' for software deployment

Bug #1407387 reported by huangtianhua
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
huangtianhua

Bug Description

create a stack with software deployment resource and didn't specific the 'config' property, the stack create failed, the reason is :
http://paste.openstack.org/show/155496/

Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/144865

Changed in heat:
status: New → In Progress
Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → Medium
milestone: none → kilo-2
Revision history for this message
Steve Baker (steve-stevebaker) wrote : Re: Make some properties required for software deployment

See inline comments in the review, I would prefer the resource to handle missing config or server gracefully rather than making them mandatory

Angus Salkeld (asalkeld)
Changed in heat:
milestone: kilo-2 → kilo-3
summary: - Make some properties required for software deployment
+ Make properties ‘config’ required for software deployment
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/144865
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1e82f2c2c35155e0c441e2c57a7b7c9cca208fce
Submitter: Jenkins
Branch: master

commit 1e82f2c2c35155e0c441e2c57a7b7c9cca208fce
Author: huangtianhua <email address hidden>
Date: Sun Jan 4 16:04:22 2015 +0800

    Allow empty 'config' for software deployment

    Allow empty 'config' for software deployment resource.
    The use case would be for custom agents where the config
    is already baked into the image, so these agents would
    still want to:
      read input_values to feed into the baked-in config
      signal heat that deployment is complete, including output values

    Change-Id: I616640f7fa158576ca65ee7ed4075c38928a81a9
    Closes-Bug: #1407387

Changed in heat:
status: In Progress → Fix Committed
summary: - Make properties ‘config’ required for software deployment
+ Allow empty 'config' for software deployment
description: updated
Revision history for this message
Steve Baker (steve-stevebaker) wrote :

does this mean that there are tripleo templates which have deployment resources which don't specify a config_id?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/164115

Changed in heat:
milestone: kilo-3 → kilo-rc1
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/164115
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=a272b3f8d913016a19f09c04c740e43fbd871d11
Submitter: Jenkins
Branch: master

commit a272b3f8d913016a19f09c04c740e43fbd871d11
Author: huangtianhua <email address hidden>
Date: Fri Mar 13 16:14:05 2015 +0800

    Allow empty 'config' for software deployments

    Allow empty 'config' for software deployment resources.
    The use case would be for custom agents where the config
    is already baked into the image, so these agents would
    still want to:
      read input_values to feed into the baked-in config
      signal heat that deployment is complete, including output values

    Change-Id: I87807065bf5821bcff23810d7e58c34eaa991f19
    Closes-Bug: #1407387

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.