pep8 H302 failing on stable/juno with latest hacking

Bug #1407024 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Matt Riedemann
Juno
Fix Released
Undecided
Unassigned

Bug Description

mriedem@ubuntu:~/git/nova$ tox -r -e pep8
pep8 recreate: /home/mriedem/git/nova/.tox/pep8
pep8 installdeps: -r/home/mriedem/git/nova/requirements.txt, -r/home/mriedem/git/nova/test-requirements.txt
pep8 develop-inst: /home/mriedem/git/nova
pep8 runtests: PYTHONHASHSEED='0'
pep8 runtests: commands[0] | flake8
./nova/tests/compute/test_resources.py:30:1: H302 import only modules.'from nova.tests.fake_instance import fake_instance_obj' does not import a module
./nova/tests/compute/test_rpcapi.py:31:1: H302 import only modules.'from nova.tests.fake_instance import fake_instance_obj' does not import a module
ERROR: InvocationError: '/home/mriedem/git/nova/.tox/pep8/bin/flake8'
___________________________________________________________________________________________ summary ___________________________________________________________________________________________
ERROR: pep8: commands failed

I'm not sure what changed, I'm assuming a new version of hacking was released that hits problems in stable/juno.

Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Hans Lindgren (hanlind) wrote :

Looks like the following fix should be backported: https://review.openstack.org/140172

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/144748

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/juno)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/144748
Reason: https://review.openstack.org/#/c/140172/ needs to be backported.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/144760

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/juno)

Reviewed: https://review.openstack.org/144760
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5e44c9f7d43ead980ec58fcabbe8036f3234030e
Submitter: Jenkins
Branch: stable/juno

commit 5e44c9f7d43ead980ec58fcabbe8036f3234030e
Author: Sean Dague <email address hidden>
Date: Mon Dec 8 17:38:46 2014 -0500

    fix pep8 errors that apparently slipped in

    Apparently, a couple of H302 issues have slipped into Nova, possibly
    due to hacking releases or a bad merge commit. Fix these as they are
    blocking some other patches.

    Conflicts:
            nova/tests/unit/compute/test_resources.py
            nova/tests/unit/compute/test_rpcapi.py

    Closes-Bug: #1407024

    Change-Id: Icc42e060492bc74febc9414b63970ee71fb9c27c
    (cherry picked from commit f3b9d9e7b9a123e55a48393bd07e491ca03bd8f3)

tags: added: in-stable-juno
Joe Gordon (jogo)
Changed in nova:
status: Triaged → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.