open-ils.actor.user.checked_out.count.authoritative could be called less

[Jason Stephenson]

Eg Version: 2.7.1 & master as of 20141220 (probably affects older versions)
OpenSRF: master as of 20141220 (but probably irrelevant)
Postgres: 9.1.something (also irrelevant)
O/S: Ubuntu 12.04 (precise pangolin) & 14.04 (trust tahr)

Just retrieving a patron by barcode via the staff client calls open-ils.actor.user.checked_out.count.authoritative 6 times. It should probably only be called once.

If you look closely at the attached log, this makes 6 calls to open-ils.cstore.direct.action.open_circ_count.retrieve and each one appears to have gone to a different cstore drone, thus temporarily tying up 5 more drones than necessary.

[Jeff Godin (jgodin)]

Confirmed in 2.5 as well.

Some additional data:

Four of the six calls to open-ils.actor.user.checked_out.count.authoritative come from the function patron.util.set_penalty_css

When retrieving a patron, set_penalty_css is called twice, and that function calls:
* open-ils.actor.user.fines.summary.authoritative
* open-ils.actor.user.checked_out.count.authoritative
* open-ils.actor.note.retrieve.all.authoritative
* open-ils.actor.user.checked_out.count.authoritative (yes, a second time)

The other two calls to open-ils.actor.user.checked_out.count.authoritative are in patron/summary.js and circ/checkout.js

[Terran McCanna (tmccanna)]

Is this still an issue in the web client?

[Terran McCanna (tmccanna)]

(Assuming this is no longer an issue since the patron screens have been entirely overhauled, so marking this Won't Fix, but can change back if needed.)