opening preferences resets deck eq knobs
Bug #1406610 reported by
RJ Skerry-Ryan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
High
|
Owen Williams |
Bug Description
Something is likely doing engine-changing work in the slotUpdate call.
Changed in mixxx: | |
importance: | Undecided → High |
status: | New → Confirmed |
milestone: | none → 1.12.0 |
Changed in mixxx: | |
status: | In Progress → Fix Committed |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is because applySelections() is getting called when the prefs window opens, and reloading the EQ effects resets the knobs.
The thing to do would be to check that the currently-loaded effect matches the configured effect, but I can't figure out how to get the id of an instantiated effect. the getId method is static per-GroupEffect Processor, and that isn't exposed in the parent classes because you can't have static virtual methods. I think the solution is to make getId not static, then I can do a crazy call in dlgprefeq like:
QString current_effect = m_pEQEffectRack ->getEffectChai nSlot(deck) ->getEffectSlot (0)->getEffect( )->getEngineEff ect()-> getId() ;
(obviously checking for null pointers along the way)