the code of get_token_provider in token.provider.py does not match docstring
Bug #1406172 reported by
wanghong
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Identity (keystone) |
Fix Released
|
Low
|
wanghong |
Bug Description
The docstring says "Return the provider based on ``token_format`` if ``provider`` is not set. Otherwise, ignore ``token_format`` and return the configured ``provider`` instead.", refer to: https:/
However, the codes check CONF.signing.
Changed in keystone: | |
assignee: | nobody → wanghong (w-wanghong) |
Changed in keystone: | |
status: | New → In Progress |
description: | updated |
tags: | added: documentation |
description: | updated |
Changed in keystone: | |
milestone: | none → kilo-3 |
status: | Fix Committed → Fix Released |
Changed in keystone: | |
milestone: | kilo-3 → 2015.1.0 |
To post a comment you must log in.
I think the documentation here is correct because it states the reason for checking signing. token_format is to be backwards compatible [1]. The doc string says that the value *should* come from token.provider, but we have to check signing. token_format as well. I think this can be grouped in the 'removed- as-of-kilo' bucket since it clearly states that in the doc string. Now that we are in the Kilo development cycle, I think that could be refactored.
[1] https:/ /github. com/openstack/ keystone/ blob/f5c06d619c 762d5d39e8ec3bc 752215ec02b2756 /keystone/ token/provider. py#L123- L125