the code of get_token_provider in token.provider.py does not match docstring

[wanghong]

The docstring says "Return the provider based on ``token_format`` if ``provider`` is not set. Otherwise, ignore ``token_format`` and return the configured ``provider`` instead.", refer to: https://github.com/openstack/keystone/blob/f5c06d619c762d5d39e8ec3bc752215ec02b2756/keystone/token/provider.py#L127

However, the codes check CONF.signing.token_format first and then check CONF.token.provider.

[Lance Bragstad (lbragstad)]

I think the documentation here is correct because it states the reason for checking signing.token_format is to be backwards compatible [1]. The doc string says that the value *should* come from token.provider, but we have to check signing.token_format as well. I think this can be grouped in the 'removed-as-of-kilo' bucket since it clearly states that in the doc string. Now that we are in the Kilo development cycle, I think that could be refactored.

[1] https://github.com/openstack/keystone/blob/f5c06d619c762d5d39e8ec3bc752215ec02b2756/keystone/token/provider.py#L123-L125

[Lance Bragstad (lbragstad)]

Looks like this is the patch addressing this:

https://review.openstack.org/#/c/144250/3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/144250
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5774f297996942beecfcd32662e5c7c738fdbb01
Submitter: Jenkins
Branch: master

commit 5774f297996942beecfcd32662e5c7c738fdbb01
Author: wanghong <email address hidden>
Date: Mon Dec 29 12:00:30 2014 +0800

    remove the Conf.signing.token_format option support

    In the doc string, it clearly states that we ensure backwards
    compatibility for Conf.signing.token_format until Havana + 2.
    Now, we are in the Kilo development cycle, we can remove this
    support.

    partially-implements blueprint removed-as-of-kilo
    Closes-Bug: #1406172
    Change-Id: I3cd1e2e5a51c4a87edf00647bc1b95a0347e3316