Vinyl control broken, pitch-independent scalar being triggered rapidly

[Owen Williams]

https://github.com/mixxxdj/mixxx/commit/ac7779fe6a0626ff14cd4de689dc59cec440f6c5#commitcomment-9103474

The pitch keycontrol changes broke vinyl control. The "pitch" CO is being set based on the speed of the current playback, but it's not being updated quickly enough to keep up with the vinyl control speed changes. Hopefully it's just an off-by-one-buffer issue -- the keycontrol object should get its rate updates directly by function calls, not CO changes. That way we can call calculateSpeed in enginebuffer and then pass the result directly into the keycontrol object.

[Daniel Schürmann (daschuer)]

Does Vinyl control effect the speed slider "rate" control ?
The pitch calculation currently relies on the rate control.
I have changed the code that we read the rate co only at one point and pipe it to calculateSpeed().
But this is discarded in case of vinyl control.
This seams the core issue.

[Owen Williams (ywwg)]

Yes, vinyl control updates the slider, but it is smoothed from the actual vinyl rate so the slider is more of a visual approximation than an actual rate.

There are other cases when the slider lies, such as when the speed is out of slider range.

You should not rely on the rate slider for an accurate measure of playback speed.

[Owen Williams (ywwg)]

https://github.com/mixxxdj/mixxx/pull/441

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7774