Remove environment name restrictions

Bug #1405788 reported by Ekaterina Chernova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Low
zhurong

Bug Description

Previously, environment name used in heat stack name and because of that there were some restrictions on environment name.

But now, environment name is not used anywhere in engine at all. So user can can set any name to group of applications. (environment)

Tags: api dashboard
Changed in murano:
milestone: none → kilo-2
assignee: nobody → Ekaterina Chernova (efedorova)
importance: Undecided → Medium
status: New → Confirmed
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/144305

Changed in murano:
status: In Progress → Won't Fix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/152559

Changed in murano:
status: Won't Fix → In Progress
Changed in murano:
milestone: kilo-2 → 2015.1
Changed in murano:
assignee: Ekaterina Chernova (efedorova) → Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: 2015.1.0 → none
Changed in murano:
status: In Progress → Confirmed
milestone: none → liberty-1
Changed in murano:
milestone: liberty-1 → liberty-2
Changed in murano:
milestone: liberty-2 → liberty-3
Changed in murano:
milestone: liberty-3 → liberty-rc1
Changed in murano:
assignee: Kirill Zaitsev (kzaitsev) → nobody
Changed in murano:
importance: Medium → Low
milestone: liberty-rc1 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on murano (master)

Change abandoned by Ekaterina Chernova (<email address hidden>) on branch: master
Review: https://review.openstack.org/144305

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Ekaterina Chernova (<email address hidden>) on branch: master
Review: https://review.openstack.org/152559

Changed in murano:
milestone: next → mitaka-1
Changed in murano:
assignee: nobody → Nikolay Starodubtsev (starodubcevna)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/237458

Changed in murano:
status: Confirmed → In Progress
tags: added: api dashboard
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/237458
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=ac2b523302604abca83212233d5d68ea43651877
Submitter: Jenkins
Branch: master

commit ac2b523302604abca83212233d5d68ea43651877
Author: Nikolay Starodubtsev <email address hidden>
Date: Mon Oct 19 17:20:25 2015 +0300

    Remove obsolete names checks

    Since we don't use environments and environment templates names during
    deployment process we don't need to check what is the name of the
    environment. Now we should only keep it human-readable and check that
    it exists.

    Partial-Bug: #1405788
    Change-Id: I88b447e0dbe9fde07602d4ce1e746c1ccfa62637

Changed in murano:
milestone: mitaka-1 → mitaka-2
Revision history for this message
Nikolay Starodubtsev (starodubcevna) wrote :

Need to remove restriction from murano-dashboard. API side is okay now.

Changed in murano:
status: In Progress → Confirmed
assignee: Nikolay Starodubtsev (starodubcevna) → nobody
zhurong (zhu-rong)
Changed in murano:
assignee: nobody → zhurong (zhu-rong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/260972

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
Dmytro Dovbii (ddovbii) wrote :

what about security groups? we use name of environment as a part of security group name:
https://github.com/openstack/murano/blob/master/meta/io.murano/Classes/system/SecurityGroupManager.yaml#L25
if we delete these restrictions, will Heat be able to create groups?

Changed in murano:
assignee: zhurong (zhu-rong) → Kirill Zaitsev (kzaitsev)
Changed in murano:
assignee: Kirill Zaitsev (kzaitsev) → zhurong (zhu-rong)
Changed in murano:
milestone: mitaka-2 → mitaka-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/260972
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=4b7846ae4a239c19858770ef678b8e60d617310d
Submitter: Jenkins
Branch: master

commit 4b7846ae4a239c19858770ef678b8e60d617310d
Author: zhurong <email address hidden>
Date: Sat Dec 19 00:23:28 2015 +0800

    Remove environment name restrictions

    Since we don't use environments and environment templates names during
    deployment process we don't need to check what is the name of the
    environment. Now we should only keep it human-readable and check that
    it exists.

    Change-Id: I2d665b41deebf0c008d8b2b71802a1ab2c6673e8
    Closes-Bug: #1405788

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano-dashboard 2.0.0.0b3

This issue was fixed in the openstack/murano-dashboard 2.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.