contrib/endpoint_filter/backends/sql.py should not return db object

Bug #1405710 reported by wanghong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
wanghong

Bug Description

Manager or controller should adapt different backends. This requires all backends return the same data structure(keystone uses dict). But, currently, some list methods in contrib/endpoint_filter/backends/sql.py return db object.

wanghong (w-wanghong)
Changed in keystone:
assignee: nobody → wanghong (w-wanghong)
wanghong (w-wanghong)
summary: - some issues in contrib/endpoint_filter/backends.sql
+ contrib/endpoint_filter/backends.sql should not return db_object
summary: - contrib/endpoint_filter/backends.sql should not return db_object
+ contrib/endpoint_filter/backends.sql.py should not return db object
summary: - contrib/endpoint_filter/backends.sql.py should not return db object
+ contrib/endpoint_filter/backends/sql.py should not return db object
wanghong (w-wanghong)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/144084

Changed in keystone:
status: New → In Progress
Changed in keystone:
milestone: none → kilo-2
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/144084
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=1faf9f15c96997de89550ce60de3ce8b4e7851d2
Submitter: Jenkins
Branch: master

commit 1faf9f15c96997de89550ce60de3ce8b4e7851d2
Author: wanghong <email address hidden>
Date: Fri Dec 26 14:05:30 2014 +0800

    let endpoint_filter sql backend return dict data

    Manager or controller should adapt different backends. This requires
    all backends return the same data structure(keystone uses dict). But,
    currently, some list methods in contrib/endpoint_filter/backends/sql.py
    return db object.

    Change-Id: I30e9a0fecb1c6af67e9704b777e5822797d1b7f5
    Closes-Bug: #1405710

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.