[ui] It's impossible to delete node from deployed environment
Bug #1405635 reported by
Julia Aranovich
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Released
|
High
|
Przemyslaw Kaminski |
Bug Description
Steps to reproduce:
1. deploy an environment;
2. delete some nodes (mark it as 'pending_deletion')
Expected result:
Deploy Changes button is available due to changes in env nodes.
Actual result:
Deploy changes button id locked. It is impossible to start deployment and undeploy selected nodes.
Changed in fuel: | |
assignee: | Fuel UI Team (fuel-ui) → Przemyslaw Kaminski (pkaminski) |
status: | New → In Progress |
tags: | added: system-test-not-required |
To post a comment you must log in.
Well, it is caused by this check (in nailgun/ static/ js/views/ cluster_ page_subviews. jsx):
disabled = {... || !nodes. reject( {status: 'ready'}).length }
which actually can be written more cleary & efficiently in this way:
disabled = { ... || nodes.every( {status: 'ready'}) }
So my question is: why do we check if every node is ready? Shouldn't we also include a 'pending_deletion' check there? So the above condition would be rewritten as
disabled = {... || nodes.every( {status: 'ready', pending_deletion: false}) }