misc-sanity-checks.sh doesn't work on OS X

Bug #1405584 reported by John Schwarz
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
YAMAMOTO Takashi

Bug Description

The patch introduced by https://review.openstack.org/#/c/143539/ changed the sanity script to do all sorts of tests. Among those, it creates a new temporary directory using /bin/mktemp.

On OS X, the executable is present in /usr/bin/mktemp.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143947

Changed in neutron:
assignee: nobody → John Schwarz (jschwarz)
status: New → In Progress
Changed in neutron:
importance: Undecided → Low
milestone: none → kilo-2
Changed in neutron:
assignee: John Schwarz (jschwarz) → YAMAMOTO Takashi (yamamoto)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by John Schwarz (<email address hidden>) on branch: master
Review: https://review.openstack.org/143947
Reason: Fixed by https://review.openstack.org/#/c/143797/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/143797
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a640318bda7e94278434bafba75d39052ef217ab
Submitter: Jenkins
Branch: master

commit a640318bda7e94278434bafba75d39052ef217ab
Author: YAMAMOTO Takashi <email address hidden>
Date: Wed Dec 24 17:21:35 2014 +0900

    misc-sanity-checks.sh: Some cleanups

    Some cleanups for commit 4fdda65a5b9f379af997e1e971865ccfa7a93156.

    - Don't assume the path of mktemp command. It's /usr/bin/mktemp
      for some platforms. eg. NetBSD. Also, always provide a template
      as it's necessary for some platforms, eg. OS X. This snippet was
      taken from the example in NetBSD's mktemp(1).
    - Move a comment to the appropriate place.
    - Improve a regex to ignore more comments.
    - As the pattern for find -path is not a regex, no escape is necessary
      for period.

    Closes-Bug: #1405584
    Change-Id: Ia8358f0f7ebe9bc445ce5aa3c4f340546f37db05

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.