endpoint group filters are not applied on getting token

Bug #1405574 reported by wanghong
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
In Progress
Wishlist
Vishakha Agarwal

Bug Description

The spec of endpoint-group-filter(https://github.com/openstack/keystone-specs/blob/master/specs/juno/endpoint-group-filter.rst#performance-impact) says "Generally speaking this change should reduce the size of the service catalog included in project scoped tokens since we are filtering service endpoints.". That is to say, we should apply endpoint group filters on getting token. But, actually, we don't. Refer to:
https://github.com/openstack/keystone/blob/master/keystone/contrib/endpoint_filter/backends/catalog_sql.py#L34
Note that, in fact, the method self.endpoint_filter_api.list_endpoints_for_project just lists endpoint_proejct_associations for project rather than endpoints.

https://github.com/openstack/keystone/blob/master/keystone/contrib/endpoint_filter/controllers.py#L101
Here, we really apply endpoint group filters on endpoints.

wanghong (w-wanghong)
Changed in keystone:
assignee: nobody → wanghong (w-wanghong)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/144187

Changed in keystone:
status: New → In Progress
wanghong (w-wanghong)
description: updated
description: updated
Changed in keystone:
milestone: none → kilo-rc1
Changed in keystone:
importance: Undecided → Medium
Changed in keystone:
milestone: kilo-rc1 → liberty-1
Changed in keystone:
milestone: liberty-1 → liberty-2
Changed in keystone:
milestone: liberty-2 → liberty-3
Changed in keystone:
milestone: liberty-3 → none
Revision history for this message
Sean Perry (sean-perry-a) wrote :

I am working on rejuvenating reviews 167675 and 144187.

Changed in keystone:
assignee: wanghong (w-wanghong) → Sean Perry (sean-perry-a)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Steve Martinelli (<email address hidden>) on branch: master
Review: https://review.openstack.org/144187
Reason: patch clean up, lots of negative comments and no movement in many months, abandoning

Changed in keystone:
status: In Progress → Confirmed
Changed in keystone:
importance: Medium → Wishlist
Revision history for this message
Steve Martinelli (stevemar) wrote :

Automatically unassigning due to inactivity.

Changed in keystone:
assignee: Sean Perry (sean-perry-a) → nobody
Changed in keystone:
assignee: nobody → Vishakha Agarwal (vishakha.agarwal)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.opendev.org/743489

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by "Gage Hugo <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/keystone/+/743489
Reason: Abandoning since there hasn't been any recent activity, if anyone wants to continue this work, please feel free to restore this or create a new change.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.