OpenStack Dashboard (Horizon)

teardown method for integration_tests does not close the browser if logout/login fails

Bug #1405553 reported by Amogh
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Amogh
OpenStack Dashboard (Horizon) 2015.1.0 "kilo"

Bug Description

teardown method for integration_tests does not close the browser if logout/login fails.

1. If logout/login fails, then teardown method does not close the browser window.

See original description
Amogh (amogh-r-mavinagidad)
Changed in horizon:
assignee: nobody → Amogh (amogh-r-mavinagidad)
Amogh (amogh-r-mavinagidad)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/145936

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/145936
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=cc373e3244d050ae35941462786eb4839e5e85d1
Submitter: Jenkins
Branch: master

commit cc373e3244d050ae35941462786eb4839e5e85d1
Author: mavinagi <email address hidden>
Date: Thu Jan 8 15:13:32 2015 -0600

    Modified teardown method to handle login and logout failure.

    In TestCase and AdminTestCase
     * Added condition to check login status inside teardown method.
     * Added try and finally, in case logout fails.
    In BaseTestCase->teardown:
     * replaced driver.close() with driver.quit()

    Partially implements blueprint: selenium-integration-testing
    Closes-Bug: #1405553

    Change-Id: Id1b520ec0a747ace89864bf7cc6b5d9b670fdc60

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-2 → 2015.1.0
Revision history for this message
Sergei Chipiga (schipiga) wrote :

It's due to in unittest teardown is not executed if setup is failed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/323990

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/323990
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c3da75ab5a7f157d1650e08d17bfeef06a0feb62
Submitter: Jenkins
Branch: master

commit c3da75ab5a7f157d1650e08d17bfeef06a0feb62
Author: Sergei Chipiga <email address hidden>
Date: Wed Jun 1 18:39:19 2016 +0300

    Delegate tearDown logic to addCleanup method

    tearDown doesn't work if setUp is failed, for ex.
    https://bugs.launchpad.net/searchlight/+bug/1557287
    https://bugs.launchpad.net/horizon/+bug/1405553

    Change-Id: I4e02dfbd6dc902d50dd47f8441919aa5e29b3101
    Closed-Bug: #1405553

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.