Migration of legacy router to distributed router should remove the original gateway port

[Xurong Yang]

In the case of update legacy router to distributed router, if hosting to the same node, qg port can not be added to snat router because it have not been removed from original centralized router, otherwise, qg port remains in the original centralized router. I think original qg port should be removed when updating the legacy router to distributed router.

operation defined as follow:
neutron router-create dvr
neutron router-gateway-set dvr ext-net

neutron router-interface-add dvr vxlan-subnet1

neutron router-update dvr --distributed=true

we can find qg port is still in qrouter after updating operation.

[Swaminathan Vasudevan (swaminathan-vasudevan)]

Are you currently working on this patch. If not please let us know and we can take up this patch.

[Mike Smith (michael-smith6)]

The router needs to be disabled via 'admin_state_up=False' prior to migration. Your steps should look like this -
neutron router-create dvr
neutron router-gateway-set dvr ext-net

neutron router-interface-add dvr vxlan-subnet1

neutron router-update dvr --admin_state_up=False
neutron router-update dvr --distributed=true
neutron router-update dvr --admin_state_up=True

Can you try to reproduce with the steps above? Otherwise I think this is not a bug.

[Xu Han Peng (xuhanp)]

I am seeing the same problem during migration.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/151181

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kyle Mestery (<email address hidden>) on branch: master
Review: https://review.openstack.org/151181
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.