hang at 'deploying' state if can not get root_uuid

Bug #1405519 reported by Haomeng,Wang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Ramakrishnan G (rameshg87)

Bug Description

https://github.com/openstack/ironic/blob/80670140b19e1d5daf9c7aebd4c90771667d8e66/ironic/drivers/modules/pxe.py#L471

        if not root_uuid:
            return

Here should raise exception to avoid hang at 'deploying' state if we can not get the root_uuid for some case.

Haomeng,Wang (whaom)
Changed in ironic:
assignee: nobody → Haomeng,Wang (whaom)
summary: - hang if can not get root_uuid
+ hang at 'deploying' state if can not get root_uuid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143919

Changed in ironic:
status: New → In Progress
Haomeng,Wang (whaom)
Changed in ironic:
importance: Undecided → Medium
milestone: none → kilo-3
Haomeng,Wang (whaom)
Changed in ironic:
milestone: kilo-3 → none
Haomeng,Wang (whaom)
Changed in ironic:
assignee: Haomeng,Wang (whaom) → nobody
Revision history for this message
John Stafford (john-stafford) wrote :

Hi Haomeng,

Are you still working this, or is it abandoned/waiting for someone else to pick it up??

Revision history for this message
Haomeng,Wang (whaom) wrote :

Yes, John, I am back from my new year vacation, so will pick this up soon, thanks for your kindly reminder.

Changed in ironic:
assignee: nobody → Haomeng,Wang (whaom)
Revision history for this message
John Stafford (john-stafford) wrote :

Thank you very much for the response Haomeng. Hope you had a fun New Year :-)

Changed in ironic:
assignee: Haomeng,Wang (whaom) → Ramakrishnan G (rameshg87)
Changed in ironic:
assignee: Ramakrishnan G (rameshg87) → Haomeng,Wang (whaom)
Changed in ironic:
assignee: Haomeng,Wang (whaom) → Ramakrishnan G (rameshg87)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/143919
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=75fbef22b6d9a58687a58a9413df21bd2fa90a00
Submitter: Jenkins
Branch: master

commit 75fbef22b6d9a58687a58a9413df21bd2fa90a00
Author: Ramakrishnan G <email address hidden>
Date: Thu Mar 19 10:28:19 2015 +0000

    Fail deploy if root uuid or disk id isn't available

    Makes the vendor passthrus pass_deploy_info of pxe
    and ilo deploys to fail the deploy if root uuid or
    disk id isn't available.

    Closes-Bug: 1405519
    Change-Id: Icb4771ad4ec2b8a32890e8324a9d23747225a909

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.