storpool driver doesn't follow recommended logging format

Bug #1405299 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Invalid
Undecided
Unassigned

Bug Description

storpool driver is super light on Logging (maybe that's good, maybe that's bad). Seems like there could be a bit more logging added here to help operators out.

The entirety of the logging is shown below, and the formatting of the logging messages is incorrect:

                LOG.error(
                    _LE('Could not remove the temp snapshot {n} for {v}: {e}').
                    format(n=name, v=volname, e=six.text_type(e)))

                LOG.error(
                    _LE('Could not remove the temp snapshot {n} for {v}: {e}').
                    format(n=name, v=volname, e=six.text_type(e)))

                LOG.error(_LE("Could not delete the temp snapshot {n}: {msg}").
                          format(n=snapname, msg=six.text_type(e)))

               LOG.error(_LE("StorPoolDriver API initialization failed: {e}").
                         format(e=e))

Should follow guidelines from here: http://docs.openstack.org/developer/oslo.i18n/guidelines.html

liaonanhai (nanhai-liao)
Changed in cinder:
assignee: nobody → liaonanhai (nanhai-liao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143762

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Mike Perez (<email address hidden>) on branch: master
Review: https://review.openstack.org/143762
Reason: Over a month with no update.

Mike Perez (thingee)
Changed in cinder:
assignee: liaonanhai (nanhai-liao) → nobody
status: In Progress → Confirmed
Changed in cinder:
assignee: nobody → hardik (hardik-parekh047)
Revision history for this message
Hardik Parekh (hardik-parekh047) wrote :

This file is no longer exist so This is not a valid bug.

Changed in cinder:
assignee: hardik (hardik-parekh047) → nobody
Changed in cinder:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.