Incorrect disk_cachemodes conf line

[Praveen Yalagandula]

Noticed in 5.1 with Ubuntu 12.04, but seems like the bug exists in trunk too.

In nova-compute logs, noticed the following WARNING:
2014-12-23 01:16:38.243 15664 WARNING nova.virt.libvirt.driver [-] Invalid cachemode directsync" specified for disk type file.

nova.conf contains the following line [libvirt] section:
disk_cachemodes="file=directsync","block=none"

The above should be:
disk_cachemodes="file=directsync,block=none"

Looks like fuel-library/deployment/puppet/openstack/manifests/compute.pp has the bug on lines 331 and 338:
331 libvirt_disk_cachemodes => ['"file=directsync"','"block=none"'],

[Bartłomiej Piotrowski (bpiotrowski)]

Already fixed in c0730b265fadb.

[Tomasz 'Zen' Napierala (tzn)]

Please provide convenient link to review and mark bug as duplicate, if this is a case

[Bartłomiej Piotrowski (bpiotrowski)]

After a second glance, I completely misread the report, so re-opening.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/144596

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/144596
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=3eb5e8ae7ad8cc38b20fcba5cb52b4025e190c1d
Submitter: Jenkins
Branch: master

commit 3eb5e8ae7ad8cc38b20fcba5cb52b4025e190c1d
Author: Bartłomiej Piotrowski <email address hidden>
Date: Wed Dec 31 08:54:26 2014 +0100

    Remove unnecessary quotation marks from nova disk cachemodes

    Change-Id: I061a4a221c9c0408c36d621bf9ddf9f3b95fb62c
    Closes-Bug: 1405040

[Alexander Nevenchannyy (anevenchannyy)]

Verified on MOS 6.1 ISO #429
Steps to Verify:
root@node-4:~# grep disk_cachemodes /etc/nova/nova.conf
disk_cachemodes="network=writeback,block=none"