Default formatting tag "break" does not work anymore
Bug #1404638 reported by
Oliver Wieland
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Released
|
Medium
|
Tim Bentley | ||
Bug Description
- kubuntu 14.10
- openlp tunk
Due to the formatting validation, which checks any song verse for opened / closed tags in the right order, the formatting tag "break" does not work anymore.
The reason is simple: There is no closing tag {/br} for this, so the validation fails and the verse cannot be saved.
I do not have a solution at this time.
Related branches
lp:~trb143/openlp/bug-1404638
- Raoul Snyman: Approve
-
Diff: 201 lines (+74/-13)7 files modifiedopenlp/core/common/uistrings.py (+1/-1)
openlp/plugins/custom/lib/mediaitem.py (+1/-1)
openlp/plugins/media/lib/mediaitem.py (+3/-5)
openlp/plugins/remotes/lib/httprouter.py (+3/-3)
openlp/plugins/songs/forms/editsongform.py (+8/-2)
tests/functional/openlp_core_utils/test_utils.py (+1/-1)
tests/functional/openlp_plugins/songs/test_editsongform.py (+57/-0)
| description: | updated |
Revision history for this message
| Tomas Groth (tomasgroth) wrote | #1 |
Revision history for this message
| Oliver Wieland (oliwee) wrote | #2 |
| Changed in openlp: | |
| assignee: | nobody → Tim Bentley (trb143) |
| Changed in openlp: | |
| milestone: | none → 2.1.2 |
| status: | New → Fix Committed |
| importance: | Undecided → Medium |
| Changed in openlp: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
A workaround for now could be to use "{br}{/br}".
We should probably introduce support for tags without content, like "{br/}". Don't know how hard/easy that will be...