Unit tests for zfssa driver don't actually check anything
Bug #1404339 reported by
John Griffith
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Undecided
|
abhiram moturi |
Bug Description
Noticing a number of submissions lately where unit tests were just calling a driver method, but never actually checking results or behaviors; in other words "I sent the call and it didn't blow up so I must be ok", hardly a good unit test IMO.
So I started looking around and found there are some unit tests that we let in that do this very thing. The zfssa test is one example; this should be fixed up to have proper unit testing and we should be a bit more careful about this sort of thing in our reviews (myself included obviously).
Changed in cinder: | |
assignee: | nobody → Juan Zuluaga (juan-c-zuluaga) |
status: | New → In Progress |
Changed in cinder: | |
assignee: | Juan Zuluaga (juan-c-zuluaga) → abhiram moturi (abhiram-moturi) |
tags: | added: zfssa |
Changed in cinder: | |
milestone: | none → liberty-3 |
status: | Fix Committed → Fix Released |
Changed in cinder: | |
milestone: | liberty-3 → 7.0.0 |
To post a comment you must log in.
Definitely this has to be improved.
Nevertheless, not all zfssa unit tests don't check anything.