Fuel for OpenStack

Nailgun: test's datadiff doesn't raise error if we have extra fields

Bug #1404334 reported by Ihor Kalnytskyi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Ihor Kalnytskyi
Fuel for OpenStack 6.1

Bug Description

In Nailgun tests we have the "datadiff" method which doesn't compare keys amount. That's wrong behavior, since extra fields will not be compared but may break puppet.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143143

Changed in fuel:
assignee: nobody → Igor Kalnitsky (ikalnitsky)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/143143
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=e4c5cb1bdbc18dd5a6a25df156b6a4f200462f8d
Submitter: Jenkins
Branch: master

commit e4c5cb1bdbc18dd5a6a25df156b6a4f200462f8d
Author: Igor Kalnitsky <email address hidden>
Date: Fri Dec 19 19:27:18 2014 +0200

    Compare .keys() anount in datadiff nodes

    We need to compare .keys() amount, since extra fields may be skipped
    but break puppet execution.

    Change-Id: I9a40efd0454af3d1c0ce42cd325a2cc54e3c94d3
    Closes-Bug: #1404334

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.