Missing TIOCNOTTY

[Vasily Postnicov]

A while ago SB-UNIX:TIOCNOTTY constant was removed. It seems it does not make much harm to anyone, but now I try cl-daemonize and it cannot be compiled because of it. I think it can be a good idea to bring this constant back anywhere with exception of HP-UX. A patch is attached.

[Douglas Katzman (dougk)]

I disagree. Systems should be using SB-POSIX. The comments about SB-UNIX in SBCL source code say:
   #s(sb-cold:package-data
      :name "SB!UNIX"
      :doc
      "private: a wrapper layer for SBCL itself to use when talking
with an underlying Unix-y operating system.
This was a public package in CMU CL, but that was different.
CMU CL's UNIX package tried to provide a comprehensive,
stable Unix interface suitable for the end user.
This package only tries to implement what happens to be
needed by the current implementation of SBCL, and makes
no guarantees of interface stability."

If some other maintainer wants to assert that the comment is wrong (and remove it), then the patch seems fine.

[Alastair Bridgewater (alastair-bridgewater)]

My basic thought here is "no". SB-UNIX is an internal package of SBCL, and
if anything breaks because of changes to it then we point to the "you get
to keep both pieces" guarantee. Adding the constant to SB-POSIX might be
more in order, and fixing cl-daemonize would be in order, but re-adding the
constant to SB-UNIX without a need internal to SBCL itself? That doesn't
seem right to me.

On Fri, Dec 19, 2014 at 11:42 AM, Vasily Postnicov <email address hidden>
wrote:
>
> Public bug reported:
>
> A while ago SB-UNIX:TIOCNOTTY constant was removed. It seems it does not
> make much harm to anyone, but now I try cl-daemonize and it cannot be
> compiled because of it. I think it can be a good idea to bring this
> constant back anywhere with exception of HP-UX. A patch is attached.
>
> ** Affects: sbcl
> Importance: Undecided
> Status: New
>
> ** Patch added: "tiocnotty.patch"
>
> https://bugs.launchpad.net/bugs/1404315/+attachment/4284250/+files/tiocnotty.patch
>
> --
> You received this bug notification because you are subscribed to SBCL.
> https://bugs.launchpad.net/bugs/1404315
>
> Title:
> Missing TIOCNOTTY
>
> Status in Steel Bank Common Lisp:
> New
>
> Bug description:
> A while ago SB-UNIX:TIOCNOTTY constant was removed. It seems it does
> not make much harm to anyone, but now I try cl-daemonize and it cannot
> be compiled because of it. I think it can be a good idea to bring this
> constant back anywhere with exception of HP-UX. A patch is attached.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/sbcl/+bug/1404315/+subscriptions
>