update on a stack having a RandomString resource fails first, succeeds on next attempt

[Unmesh Gurjar]

Branch: master

Scenario:
1. Create a stack (using attached create template).
2. Update the stack created above (using the attached update template).
3. Observe the stack status (it ends as UPDATE_FAILED).
4. Again update the stack (using the same update template).
5. Observe the stack status (it succeeds).

Actual result:
Update fails on first attempt, but passes on the second.

Expected result:
Stack update should succeed in the first attempt itself.

[Ashish Singh (ashish-singh7)]

Hi Unmesh,

Just wanted to know if I can start working on this bug as it was assigned to you.
Please let me know.

Thanks,
Ashish.

[Unmesh Gurjar (unmesh-gurjar)]

@Ashish: I couldn't focus on this issue, you can take it up.

[Ethan Lynn (ethanlynn)]

I use attached template to test and get the same result.
When update first time, I got following error:
2015-04-02 22:52:48.584 INFO heat.engine.resource [-] updating RandomString "rg" [update-rg-4dmfsiihyb7h] Stack "update" [317cb076-0b60-423b-bf5d-156b44e776a8]
2015-04-02 22:52:48.606 INFO heat.engine.resource [-] UPDATE: RandomString "rg" [update-rg-4dmfsiihyb7h] Stack "update" [317cb076-0b60-423b-bf5d-156b44e776a8]
2015-04-02 22:52:48.606 TRACE heat.engine.resource Traceback (most recent call last):
2015-04-02 22:52:48.606 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resource.py", line 489, in _action_recorder
2015-04-02 22:52:48.606 TRACE heat.engine.resource yield
2015-04-02 22:52:48.606 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resource.py", line 748, in update
2015-04-02 22:52:48.606 TRACE heat.engine.resource after_props.validate()
2015-04-02 22:52:48.606 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/properties.py", line 398, in validate
2015-04-02 22:52:48.606 TRACE heat.engine.resource raise exception.StackValidationFailed(message=msg)
2015-04-02 22:52:48.606 TRACE heat.engine.resource StackValidationFailed: Unknown Property count
2015-04-02 22:52:48.606 TRACE heat.engine.resource

That is because we create a randomstring resource name 'rg' when we create the stack, but when we updating the stack, 'rg' become
a type of resourcegroup.
stack-update go into the randomstring update logic and find out that count is not a property.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/170181

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170181
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=189324a7094dc84d8b8206df38e754ae07daf1e4
Submitter: Jenkins
Branch: master

commit 189324a7094dc84d8b8206df38e754ae07daf1e4
Author: Ethan Lynn <email address hidden>
Date: Thu Apr 2 23:40:17 2015 +0800

    Fix stack update issue

    Different type of resource with same name should consider to be a
    new resource when stack-update.

    Change-Id: I102ffbd1a1562c164f43969c87570096c280738a
    Closes-Bug: #1404201