Improve clarity, encapsulation and performance of assignment type calculation

Bug #1403929 reported by Alexander Makarov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Alexander Makarov

Bug Description

There is an assignment type calculation function in:
https://github.com/openstack/keystone/blob/master/keystone/assignment/backends/sql.py#L121-L135,
which is better to be implemented as an AssignmentType classmethod.

Changed in keystone:
assignee: nobody → Alexander Makarov (amakarov)
Changed in keystone:
status: New → In Progress
Revision history for this message
Alexander Makarov (amakarov) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/141352
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=807cd726ddd15fc335438008acf9cec0a8e43398
Submitter: Jenkins
Branch: master

commit 807cd726ddd15fc335438008acf9cec0a8e43398
Author: Alexander Makarov <email address hidden>
Date: Fri Dec 12 15:35:09 2014 +0300

    Assignment sql backend create_grant refactoring

    Moved calculate_type function to be a class method of AssignmentType.

    Change-Id: Ib0ae2c04ab8b428a8f680520d53fbeb799fae6f0
    Closes-Bug: 1403929

Changed in keystone:
status: In Progress → Fix Committed
Changed in keystone:
importance: Undecided → Medium
milestone: none → kilo-2
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.