Test cases in test_content_types.py assert 200 on POST operations

Bug #1403509 reported by Lance Bragstad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Won't Fix
Low
Unassigned

Bug Description

When adding a positive test case to keystone/tests/test_content_types.py it was discovered that several test cases in that module assert 200 OK response codes for POST operations [1]. According to the v2.0 API documentation, POST operations should result in a 201 Created response code [2].

I've submitted a patch that changes all 200 OK response codes to 201 and showcases the failures [3].

[1] https://github.com/openstack/keystone/blob/7f52036bd4dd1b8d911d56d3019fc9d8a7337d64/keystone/tests/test_content_types.py#L119-L131
[2] http://developer.openstack.org/api-ref-identity-v2.html#admin-users
[3] https://review.openstack.org/#/c/142440/

Changed in keystone:
assignee: nobody → Victor Howard (victor-r-howard)
Changed in keystone:
assignee: Victor Howard (victor-r-howard) → nobody
David Stanek (dstanek)
Changed in keystone:
importance: Undecided → Low
Revision history for this message
Morgan Fainberg (mdrnstm) wrote :

As much as the V2 API says we should be returning a 201, this is a case where we should update the documentation to show that a 200 is returned. I do not want to change the response of the API at this time (especially since v2.0 is frozen).

Changed in keystone:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on keystone (master)

Change abandoned by Dolph Mathews (<email address hidden>) on branch: master
Review: https://review.openstack.org/142440

Revision history for this message
Steve Martinelli (stevemar) wrote :

v2.0 is deprecated, no work aside from security related issues should be fixed here, especially changing return codes :)

Changed in keystone:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.