remove detail method from the LimitsController class

Bug #1403441 reported by zhangtralon
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
zhangtralon

Bug Description

we should remove the detail method from the LimitsController class because the detail is not the default method and it doesn't add the detail operation in the _setup_routes method from the class APIRouter

Revision history for this message
Matthew Gilliard (matthew-gilliard-u) wrote :

The detail method is not used in OpenStack, and is not a default method as described at https://routes.readthedocs.org/en/latest/restful.html so this looks like dead code.

Changed in nova:
status: New → Confirmed
tags: added: low-hanging-fruit
tags: added: compute
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142464

Changed in nova:
assignee: nobody → zhangtralon (zhangchunlong1)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/142464
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=41d721c06e12492f77a49e07e032f7908bba8153
Submitter: Jenkins
Branch: master

commit 41d721c06e12492f77a49e07e032f7908bba8153
Author: zhangchunlong <email address hidden>
Date: Wed Dec 17 23:08:45 2014 +0800

    remove detail method from LimitsController

    we should remove the detail method from the LimitsController class
    because the detail is not the default method and it doesn't add the
    detail operation in the _setup_routes method from the class APIRouter

    Change-Id: I7944f5d3b43433093d76d2925eaf0568c68d4a49
    Closes-Bug: #1403441

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-3 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.