neutron.cmd.sanity: Too few/wrong arguments to logging call

Bug #1403296 reported by Angus Lees
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Angus Lees

Bug Description

ofctl_arg_supported contains a bad call to LOG.debug in an exception path.

    LOG.debug("...%s. Exception: %s", (full_args, e))

This throws "TypeError: not enough arguments for format string" and
should be:

    LOG.debug("...%s. Exception: %s", full_args, e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142336

Changed in neutron:
assignee: nobody → Angus Lees (gus)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/142336
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=79f89db7fef191e22f0494b468a099edd6f0d611
Submitter: Jenkins
Branch: master

commit 79f89db7fef191e22f0494b468a099edd6f0d611
Author: Angus Lees <email address hidden>
Date: Wed Dec 17 15:07:28 2014 +1100

    Correct arguments to logging function

    ofctl_arg_supported contains a bad call to LOG.debug in an exception
    path.

        LOG.debug("...%s. Exception: %s", (full_args, e))

    This throws "TypeError: not enough arguments for format string" and
    should be:

        LOG.debug("...%s. Exception: %s", full_args, e)

    (Found via pylint)

    Change-Id: Ib14666f60b16584f225b1e0c4fed82ef7e941aac
    Closes-Bug: #1403296

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.