cname lookup contains useless condition
Bug #1402704 reported by
Ondergetekende
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
At line 118, cname lookup compares the given hostname with the configured hostname. However, the configured hostname is an array, so this condition will never match. The correct condition is self._domain_
description: | updated |
Changed in swift: | |
milestone: | none → 2.2.2 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/141818 /git.openstack. org/cgit/ openstack/ swift/commit/ ?id=bfbf0d1e78f f47937adb06bce6 48a0b915c838d1
Committed: https:/
Submitter: Jenkins
Branch: master
commit bfbf0d1e78ff479 37adb06bce648a0 b915c838d1
Author: Koert van der Veer <email address hidden>
Date: Mon Dec 15 15:56:13 2014 +0100
Remove unneeded condition
The CName loopkup middleware checked a hostname against the configured
domains. This check is likely a remnant from when cname lookup only
supported a single hostname. Now, however, the configured domain is
actually a list of domains, so checking a single hostname will never
match. The check isn't really needed anyway, as it has been broken since
swift 1.10.
Closes-Bug: #1402704 88f527cae643168 bc725b26f8d
Change-Id: If9ff345b2c7c6d