extcmd incorrectly assumes PIPE_BUF is real pipe capacity
Bug #1402675 reported by
Zygmunt Krynicki
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
PlainBox (Toolkit) |
Fix Released
|
Critical
|
Zygmunt Krynicki |
Bug Description
The code inside the glibc-based extcmd implementation is based on the assumption that a pipe may hold at most PIPE_BUF bytes. This is not correct as the actual pipe may be much larger (e.g. 1MB vs 4KB). We need to us /proc/sys/
This causes various bad side effects (manifestations) but is always observable as a "truncated" log file.
Related branches
lp:~zyga/checkbox/extcmd-fixes
- Sylvain Pineau (community): Approve
-
Diff: 117 lines (+38/-12)2 files modifiedplainbox/plainbox/vendor/extcmd/glibc.py (+29/-12)
plainbox/plainbox/vendor/glibc.py (+9/-0)
Changed in plainbox: | |
status: | In Progress → Fix Committed |
Changed in plainbox: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.