swift_ring_builder play fails if no swift_vars are declared

Bug #1402594 reported by Jesse Pretorius
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Andy McCrae
Juno
Fix Released
Medium
Jesse Pretorius

Bug Description

If swift_vars are not declared for any hosts, the swift_ring_builder play fails with the following error:

fatal: [localhost] => {'msg': "One or more undefined variables: 'dict object' has no attribute 'swift_vars'", 'failed': True}
fatal: [localhost] => {'msg': 'One or more items failed.', 'failed': True, 'changed': False, 'results': [{'msg': "One or more undefined variables: 'dict object' has no attribute 'swift_vars'", 'failed': True}]}

Changed in openstack-ansible:
milestone: none → 10.1.0
Changed in openstack-ansible:
assignee: nobody → Andy McCrae (andrew-mccrae)
Changed in openstack-ansible:
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141853

Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/141853
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=7f595aa05784997896e9c9e5e57c9f6e60c54ab3
Submitter: Jenkins
Branch: master

commit 7f595aa05784997896e9c9e5e57c9f6e60c54ab3
Author: Andy McCrae <email address hidden>
Date: Mon Dec 15 17:19:40 2014 +0000

    Allow swift_vars to not be specified for swift_hosts

    * Default swift_vars to an empty list when undefined
    * Allows default to work as expected.
    * Avoids failures based on swift_vars not existing (even though values were already defaulted)
    * Using default statements fail if the "parent" var doesn't exist.

    Change-Id: I27eb876a1a0110bfe5cb44150c7c2a96c4313f60
    Closes-Bug: #1402594

Changed in openstack-ansible:
status: In Progress → Fix Committed
Changed in openstack-ansible:
milestone: 10.1.0 → 10.1.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (juno)

Fix proposed to branch: juno
Review: https://review.openstack.org/148970

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-ansible-deployment (juno)

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: juno
Review: https://review.openstack.org/148970
Reason: This patch can't be added individually in this branch - it needs to be squashed with other patches which combined together get gating working.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (juno)

Fix proposed to branch: juno
Review: https://review.openstack.org/149230

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-ansible-deployment (juno)

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: juno
Review: https://review.openstack.org/149230
Reason: I made a mistake with the commit message.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (juno)

Reviewed: https://review.openstack.org/149209
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=e01165bcc729ba151473dfe3199f913906e8d4b9
Submitter: Jenkins
Branch: juno

commit e01165bcc729ba151473dfe3199f913906e8d4b9
Author: Jesse Pretorius <email address hidden>
Date: Mon Jan 19 17:47:38 2015 +0000

    Squash all patches required to make gating work

    This is a merge of the following patches:
    62d2525 Fixed generator type assumption error
    1339640 Allow swift_vars to not be specified for swift_hosts
    735eb68 AIO to use https to access the frozen repo
    033df65 use archive.mariadb.org for to install mariadb package
    8b9cf6e Use reliable static mirror for mariadb apt repository
    b30f9d1 Add debootstrap package to LXC package list
    5c464e1 Add swift_all inventory to swift-common play
    a88bcb7 Add swift_all inventory to swift account/container/object plays

    Change-Id: I630e38b35a00fe547ec3aaa68604a5902be4f83e
    Closes-Bug: #1399387
    Closes-Bug: #1406323
    Closes-Bug: #1399387
    Closes-Bug: #1402582
    Closes-Bug: #1402594
    Closes-Bug: #1402617
    Closes-Bug: #1409762
    Closes-Bug: #1410743
    Closes-Bug: #1411331
    Closes-Bug: #1412521

Changed in openstack-ansible:
milestone: 10.1.2 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-ansible-deployment (juno)

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: juno
Review: https://review.openstack.org/149230
Reason: mistaken commit

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (juno)

Reviewed: https://review.openstack.org/148970
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=2d6adaa79de19dfb4215f8ab0e5c16feeaa2c323
Submitter: Jenkins
Branch: juno

commit 2d6adaa79de19dfb4215f8ab0e5c16feeaa2c323
Author: Andy McCrae <email address hidden>
Date: Mon Dec 15 17:19:40 2014 +0000

    Allow swift_vars to not be specified for swift_hosts

    * Default swift_vars to an empty list when undefined
    * Allows default to work as expected.
    * Avoids failures based on swift_vars not existing (even though values were already defaulted)
    * Using default statements fail if the "parent" var doesn't exist.

    Change-Id: I27eb876a1a0110bfe5cb44150c7c2a96c4313f60
    Closes-Bug: #1402594
    (cherry picked from commit 7f595aa05784997896e9c9e5e57c9f6e60c54ab3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-ansible-deployment (juno)

Change abandoned by Jesse Pretorius (<email address hidden>) on branch: juno
Review: https://review.openstack.org/149230
Reason: never mind - borked

Changed in openstack-ansible:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.