Hyper-V: wrong constant name causes volume attach to fail

Bug #1402403 reported by Lucian Petrut
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Lucian Petrut

Bug Description

This patch https://review.openstack.org/#/c/107177/ changed a few constant names, among which _DISK_RES_SUB_TYPE to _DISK_DRIVE_RES_SUB_TYPE.

Because of a mistake when rebasing this patch https://review.openstack.org/#/c/129235/, the old constant name was used in the vmutils.get_attached_disks method. This causes volume attach to fail.

Trace: http://paste.openstack.org/show/151021/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141655

Changed in nova:
assignee: nobody → Petrut Lucian (petrutlucian94)
status: New → In Progress
Revision history for this message
Alessandro Pilotti (alexpilotti) wrote :

Can please post a stack trace?

description: updated
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/141655
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=59322cd0f0c9f9e92d1bd81b864e3a2f9f92f116
Submitter: Jenkins
Branch: master

commit 59322cd0f0c9f9e92d1bd81b864e3a2f9f92f116
Author: Lucian Petrut <email address hidden>
Date: Sun Dec 14 18:36:41 2014 +0200

    Hyper-V: Fix volume attach issue caused by wrong constant name

    This patch d5ca918af4124216e4435fdc28c9180f996e4036 changed a few
    constant names, among which _DISK_RES_SUB_TYPE to
    _DISK_DRIVE_RES_SUB_TYPE.

    Because of a mistake when rebasing this patch
    0e02db2980dc4e76ef7949ba4ec131af9fc4a44d, the old constant name
    was still used in the vmutils.get_attached_disks method, causing
    volume attachment to fail. This affects both v1 and v2 namespaces.

    This patch fixes the incorrect constant name and adds the missing
    unit test for this method.

    Change-Id: I373c687ce401129fc368bd074a859161d1813902
    Closes-bug: #1402403

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.