Cli trace back on the request of deletion default nodegroup

[Egor Kotko]

{"build_id": "2014-12-09_22-41-06", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "49", "auth_required": true, "api": "1.0", "nailgun_sha": "22bd43b89a17843f9199f92d61fc86cb0f8772f1", "production": "docker", "fuelmain_sha": "3aab16667f47dd8384904e27f70f7a87ba15f4ee", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-12-09_22-41-06", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "49", "api": "1.0", "nailgun_sha": "22bd43b89a17843f9199f92d61fc86cb0f8772f1", "production": "docker", "fuelmain_sha": "3aab16667f47dd8384904e27f70f7a87ba15f4ee", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "2c99931072d951301d395ebd5bf45c8d401301bb"}}}, "fuellib_sha": "2c99931072d951301d395ebd5bf45c8d401301bb"}

Steps to reproduce:
1. Deploy master node
2. Create env HA Ubuntu, neutron GRE; but not deploy
3. Execute command: #fuel --env 1 nodegroup --delete --default

Expected result:
Info message

Actual result:
Appears the traceback

http://paste.openstack.org/show/150393/

[Aleksey Kasatkin (alekseyk-ru)]

Reproduced on 6.0 GA.

[Aleksey Kasatkin (alekseyk-ru)]

From my POV, there are two problems here: documentation and arguments validation.

Right command format is:

# fuel --env 1 nodegroup --delete --group 1
Answer will be:
"Default node groups cannot be deleted."

See https://github.com/stackforge/fuel-web/blob/master/fuelclient/fuelclient/cli/actions/nodegroup.py#L78-L80

Some commands are documented here: http://docs.mirantis.com/openstack/fuel/fuel-6.0/operations.html#configuring-multiple-cluster-networks

All node groups commands should be documented, proper arguments validation should be added.

[Aleksey Kasatkin (alekseyk-ru)]

Sorry, right link to delete command definition is: https://github.com/stackforge/fuel-web/blob/master/fuelclient/fuelclient/cli/actions/nodegroup.py#L64-66

[Aleksey Kasatkin (alekseyk-ru)]

Separate ticket https://bugs.launchpad.net/fuel/+bug/1407646 is created for documentation team.

[Aleksey Kasatkin (alekseyk-ru)]

Does not break anything. Moved to 8.0. Documentation was fixed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/226684

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/226684
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=2be619167bd14aacc3eb88320249d8a4cdc8fc0a
Submitter: Jenkins
Branch: master

commit 2be619167bd14aacc3eb88320249d8a4cdc8fc0a
Author: Artem Roma <email address hidden>
Date: Wed Sep 23 13:25:59 2015 +0300

    Add check for required parameters to nodegroup commands

    Change-Id: I575b8f25021461a6bed85b8af8ccb889687faa5e
    Closes-Bug: #1402263

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/228848

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228848
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=2bd66f1a4878b0a6ba05da3705df991f00999273
Submitter: Jenkins
Branch: master

commit 2bd66f1a4878b0a6ba05da3705df991f00999273
Author: Artem Roma <email address hidden>
Date: Tue Sep 29 14:03:58 2015 +0300

    Fix checks for required parameters for nodegroup commands

    Change-Id: Ica428a4508006d51a7bec877c0239234c6b459c2
    Related-Bug: #1402263

[Anastasia Palkina (apalkina)]

Verified on ISO #91

[root@fuel ~]# fuel env create --name test --rel 2 --mode ha --network-mode neutron --net-segment-type gre
WARNING: GRE network segmentation type is deprecated since 7.0 release.
Environment 'test' with id=1, mode=ha_compact and network-mode=neutron was created!
[root@fuel ~]# fuel --env 1 nodegroup --delete --default
"--group" required!
[root@fuel ~]# fuel nodegroup list
id | cluster | name
---|---------|--------
1 | 1 | default
[root@fuel ~]# fuel --env 1 nodegroup --delete --group 1
Default node groups cannot be deleted.
[root@fuel ~]#

"fuel-createmirror_sha": "6e1b82b2059a20f1fa9a4d794b976edaad156b85", "shotgun_sha": "bbbfccff9eb90895b13fae3fac398e65efe646f4", "api": "1.0", "fuelmain_sha": "058e07386350bfa0a8365818cf75893949e0d863", "astute_sha": "cfd5d6b916a17ad2f73e6c567a0365845155b0e3", "fuel-ostf_sha": "1ab201cb8c3bba04522bf56ce72e863a03ff09b3", "openstack_version": "2015.1.0-8.0", "build_id": "91", "fuelmenu_sha": "e68335c88feca803c97d75ae5a6e7de1e3f330dc", "build_number": "91", "auth_required": true, "fuel-library_sha": "679c1a3f15e6c32309f2c4996aea4672b28daa1a", "fuel-nailgun-agent_sha": "00b4b11553c250f22c0079fb74c8b782dcb7b740", "fuel-nailgun_sha": "a1afcf0d0de61197c4a14aa014583583daa05836", "fuel-agent_sha": "d2103bee6e216396eb8e308ec5448328c9ee4261", "production": "docker", "python-fuelclient_sha": "2a1b048cc439986e222ece43a290b5cc68e92a77", "feature_groups": ["mirantis"], "release": "8.0", "release_versions": {"2015.1.0-8.0": {"VERSION": {"fuel-createmirror_sha": "6e1b82b2059a20f1fa9a4d794b976edaad156b85", "shotgun_sha": "bbbfccff9eb90895b13fae3fac398e65efe646f4", "api": "1.0", "fuelmain_sha": "058e07386350bfa0a8365818cf75893949e0d863", "astute_sha": "cfd5d6b916a17ad2f73e6c567a0365845155b0e3", "fuel-ostf_sha": "1ab201cb8c3bba04522bf56ce72e863a03ff09b3", "openstack_version": "2015.1.0-8.0", "build_id": "91", "fuelmenu_sha": "e68335c88feca803c97d75ae5a6e7de1e3f330dc", "build_number": "91", "fuel-library_sha": "679c1a3f15e6c32309f2c4996aea4672b28daa1a", "fuel-nailgun-agent_sha": "00b4b11553c250f22c0079fb74c8b782dcb7b740", "fuel-nailgun_sha": "a1afcf0d0de61197c4a14aa014583583daa05836", "fuel-agent_sha": "d2103bee6e216396eb8e308ec5448328c9ee4261", "production": "docker", "python-fuelclient_sha": "2a1b048cc439986e222ece43a290b5cc68e92a77", "feature_groups": ["mirantis"], "release": "8.0"}}}

[Denis Meltsaykin (dmeltsaykin)]

Closing this as Won't Fix for 7.0-updates as this is not a customer-found bug and the importance is not high.