[Online Accounts, Scopes] Remove snap-decision fallback
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Online Accounts setup for Ubuntu Touch |
Fix Released
|
High
|
Unassigned | ||
| Ubuntu UX |
Fix Released
|
High
|
Paty Davila | ||
| ubuntu-system-settings-online-accounts (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Some months ago we implemented a snap-decision for prompting the user to re-authenticate an account when the client is not connected to Mir (such is the case for scopes, accounts-polld and sync-monitor).
This change was meant to avoid falling into cases where the client would stop working because unable to obtain a new valid token, and it's working. However, it was not approved by design, and due to bug 1352251 it has a negative impact on the user experience.
Therefore, we want to get rid of it.
The implementation of the reverse trust prompt hosting will render the snap-decision unnecessary for those case where the UI-less process has a companion UI process running; for the other cases a solution is currently being discussed with design. A proposal is to let the UI-less process record the failure in a location readable by the companion UI application (which is not running at the same time), for example by mark the account as failing in the accounts DB. Additionally, it could emit a notification which, once activated, would launch the companion application. And when this application starts and detects that the account needs to be re-authenticated, it takes care of doing that.
Related branches
- David Barth (community): Approve
-
Diff: 522 lines (+23/-325)7 files modifiedonline-accounts-service/request-manager.cpp (+5/-3)
online-accounts-service/ui-proxy.cpp (+9/-9)
online-accounts-ui/globals.h (+2/-0)
online-accounts-ui/online-accounts-ui.pro (+0/-2)
online-accounts-ui/signonui-request.cpp (+7/-140)
tests/online-accounts-ui/tst_signonui_request.cpp (+0/-168)
tests/online-accounts-ui/tst_signonui_request.pro (+0/-3)
| Changed in ubuntu-ux: | |
| status: | New → Triaged |
| assignee: | nobody → Matthew Paul Thomas (mpt) |
| importance: | Undecided → High |
| Changed in ubuntu-system-settings-online-accounts: | |
| status: | Confirmed → Fix Released |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-system-settings-online-accounts (Ubuntu): | |
| status: | New → Confirmed |
| Changed in ubuntu-system-settings-online-accounts (Ubuntu): | |
| status: | Confirmed → Fix Released |
| Changed in ubuntu-ux: | |
| assignee: | Matthew Paul Thomas (mpt) → Paty Davila (dizzypaty) |
| summary: |
- Remove snap-decision fallback + [Online Accounts, Scopes] Remove snap-decision fallback |
| Changed in ubuntu-ux: | |
| status: | Triaged → In Progress |
| Changed in ubuntu-ux: | |
| status: | In Progress → Fix Released |
Status changed to 'Confirmed' because the bug affects multiple users.