Public ip addresses are collected by stats in action_logs

Bug #1401572 reported by Andrey Sledzinskiy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Aleksey Kasatkin
6.0.x
Fix Released
High
Aleksey Kasatkin
6.1.x
Fix Released
High
Aleksey Kasatkin

Bug Description

{

    "build_id": "2014-12-09_22-41-06",
    "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4",
    "build_number": "49",
    "auth_required": true,
    "api": "1.0",
    "nailgun_sha": "22bd43b89a17843f9199f92d61fc86cb0f8772f1",
    "production": "docker",
    "fuelmain_sha": "3aab16667f47dd8384904e27f70f7a87ba15f4ee",
    "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91",
    "feature_groups": [
        "mirantis"
    ],
    "release": "6.0",
    "release_versions": {
        "2014.1.3-5.1.1": {
            "VERSION": {
                "build_id": "2014-12-03_01-07-36",
                "ostf_sha": "64cb59c681658a7a55cc2c09d079072a41beb346",
                "build_number": "48",
                "api": "1.0",
                "nailgun_sha": "500e36d08a45dbb389bf2bd97673d9bff48ee84d",
                "production": "docker",
                "fuelmain_sha": "7626c5aeedcde77ad22fc081c25768944697d404",
                "astute_sha": "ef8aa0fd0e3ce20709612906f1f0551b5682a6ce",
                "feature_groups": [
                    "mirantis"
                ],
                "release": "5.1.1",
                "fuellib_sha": "a3043477337b4a0a8fd166dc83d6cd5d504f5da8"
            }
        },
        "2014.2-6.0": {
            "VERSION": {
                "build_id": "2014-12-09_22-41-06",
                "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4",
                "build_number": "49",
                "api": "1.0",
                "nailgun_sha": "22bd43b89a17843f9199f92d61fc86cb0f8772f1",
                "production": "docker",
                "fuelmain_sha": "3aab16667f47dd8384904e27f70f7a87ba15f4ee",
                "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91",
                "feature_groups": [
                    "mirantis"
                ],
                "release": "6.0",
                "fuellib_sha": "2c99931072d951301d395ebd5bf45c8d401301bb"
            }
        }
    },
    "fuellib_sha": "2c99931072d951301d395ebd5bf45c8d401301bb"

}

Steps:
1. Install fuel
2. Create and deploy any simple cluster
3. Wait until statistics will be sent by statsender to collector
4. Log in to collector database
5. Find records about deployment

Actual - there is info about user public Ip address
 {"action_group": "cluster_changes", "action_name": "deploy", "action_type": "nailgun_task", "actor_id": "a5b988672154c4c534906ae4270fabf024c5b495e68d235cc58c5fa52af24dcc", "additional_info": {"ended_with_status": "ready", "message": "Deployment of environment 'simple' is done. Access the OpenStack dashboard (Horizon) at http://10.108.1.2/ or via internal network at http://10.108.0.3/", "operation": "deploy", "output": null, "parent_task_id": null, "subtasks_ids": []}, "cluster_id": 2, "end_timestamp": "2014-12-11T15:07:44.874880", "id": 28, "is_sent": false, "start_timestamp": "2014-12-11T14:48:19.273922"}

Revision history for this message
Andrey Sledzinskiy (asledzinskiy) wrote :
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

Tasks messages are not checked yet.

Changed in fuel:
status: New → Confirmed
tags: added: usage-stats
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

Tasks messages will not be saved any longer as they are formed on the base of task status. So, status is enough for us.

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Aleksey Kasatkin (alekseyk-ru)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141102

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/141102
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=b77f20bc1a7b45dac71f02f960934270c24ccceb
Submitter: Jenkins
Branch: master

commit b77f20bc1a7b45dac71f02f960934270c24ccceb
Author: Aleksey Kasatkin <email address hidden>
Date: Thu Dec 11 19:10:16 2014 +0200

    Do not save task.message in action logs

    task.message is not saved in action logs now.
    Key "additional_info.message" is kept to keep compatibility with
    current validation and migration in collector.
    Test added.

    Change-Id: Ia85d6f4668b9be94480bd07d78fe968a805f0f97
    Closes-Bug: #1401572

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/6.0)

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/141319

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/6.0)

Reviewed: https://review.openstack.org/141319
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=7a8237fa982ed6a413e969774e7f3149a0f19ef2
Submitter: Jenkins
Branch: stable/6.0

commit 7a8237fa982ed6a413e969774e7f3149a0f19ef2
Author: Aleksey Kasatkin <email address hidden>
Date: Thu Dec 11 19:10:16 2014 +0200

    Do not save task.message in action logs

    task.message is not saved in action logs now.
    Key "additional_info.message" is kept to keep compatibility with
    current validation and migration in collector.
    Test added.

    Change-Id: Ia85d6f4668b9be94480bd07d78fe968a805f0f97
    Closes-Bug: #1401572
    (cherry picked from commit b77f20bc1a7b45dac71f02f960934270c24ccceb)

Revision history for this message
Artem Panchenko (apanchenko-8) wrote :

verified on 6.0:

api: '1.0'
astute_sha: 16b252d93be6aaa73030b8100cf8c5ca6a970a91
auth_required: true
build_id: 2014-12-18_01-32-01
build_number: '56'
feature_groups:
- mirantis
fuellib_sha: 73332192a257ea02c40a39885c502ad1ebdf3eda
fuelmain_sha: 45caacadb878abfbd9d60e134d72229698b469c9
nailgun_sha: 5f91157daa6798ff522ca9f6d34e7e135f150a90
ostf_sha: a9afb68710d809570460c29d6c3293219d3624d4
production: docker
release: '6.0'

Revision history for this message
Andrey Sledzinskiy (asledzinskiy) wrote :

verified on {

    "build_id": "2015-01-21_22-54-45",
    "ostf_sha": "c94d4dc4fde6fbd18bdfbb508f5e12e9188ad725",
    "build_number": "74",
    "auth_required": true,
    "api": "1.0",
    "nailgun_sha": "22321c5529ef95ff6586079894916f8963f4079e",
    "production": "docker",
    "fuelmain_sha": "",
    "astute_sha": "f640780d1c7ebe89e4f343736500945525799ee0",
    "feature_groups":

[

    "mirantis"

],
"release": "6.1",
"release_versions":
{

    "2014.2-6.1":

{

    "VERSION":

{

    "build_id": "2015-01-21_22-54-45",
    "ostf_sha": "c94d4dc4fde6fbd18bdfbb508f5e12e9188ad725",
    "build_number": "74",
    "api": "1.0",
    "nailgun_sha": "22321c5529ef95ff6586079894916f8963f4079e",
    "production": "docker",
    "fuelmain_sha": "",
    "astute_sha": "f640780d1c7ebe89e4f343736500945525799ee0",
    "feature_groups":

                [
                    "mirantis"
                ],
                "release": "6.1",
                "fuellib_sha": "1050db4614a0ee347757bf5aa41308a319943758"
            }
        }
    },
    "fuellib_sha": "1050db4614a0ee347757bf5aa41308a319943758"

}

tags: added: system-test-not-required
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.