os-ansible-aio-check.sh creates file called 'null'

Bug #1401567 reported by Jesse Pretorius
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Low
Jesse Pretorius
Juno
Fix Released
Low
Jesse Pretorius
Trunk
Fix Released
Low
Jesse Pretorius

Bug Description

if grep "^PermitRootLogin" /etc/ssh/sshd_config > null; then

should actually be

if grep "^PermitRootLogin" /etc/ssh/sshd_config > /dev/null; then

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141068

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/141068
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=6c7e170d98031e3da15a4b57c761cd702bdda23d
Submitter: Jenkins
Branch: master

commit 6c7e170d98031e3da15a4b57c761cd702bdda23d
Author: Jesse Pretorius <email address hidden>
Date: Thu Dec 11 15:20:11 2014 +0000

    Correctly pipe the sshd check to /dev/null

    This patch corrects the pipe of the sshd configuration check to
    /dev/null. The script therefore no longer leaves a file called 'null'
    behind on the deployment host.

    Change-Id: Ib707d7462e5e444dddceff105b219263d0283e0c
    Closes-Bug: #1401567

Changed in openstack-ansible:
status: In Progress → Fix Committed
Changed in openstack-ansible:
milestone: none → 10.1.0
Changed in openstack-ansible:
milestone: 10.1.0 → 10.1.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.