nova service-list show inconsistent output for disabled_reason

Bug #1401480 reported by jichenjc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
jichenjc

Bug Description

[root@compute1 ~]# nova service-list
+----+------------------+----------+----------+---------+-------+----------------------------+-----------------+
| Id | Binary | Host | Zone | Status | State | Updated_at | Disabled Reason |
+----+------------------+----------+----------+---------+-------+----------------------------+-----------------+
| 4 | nova-scheduler | compute1 | internal | enabled | up | 2014-12-11T10:25:17.000000 | - |
| 5 | nova-compute | compute1 | nova | enabled | up | 2014-12-11T10:25:12.000000 | - |
| 6 | nova-consoleauth | compute1 | internal | enabled | down | 2014-12-10T07:39:27.000000 | - |
| 7 | nova-compute | compute2 | nova | enabled | down | 2014-12-10T07:39:25.000000 | None |
+----+------------------+----------+----------+---------+-------+----------------------------+-----------------+

the None at disabled_reason of id 7 is inconsistent to other columns
it should be - to avoid confusion

jichenjc (jichenjc)
Changed in nova:
assignee: nobody → jichenjc (jichenjc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/141005

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/141005
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=66cad4ce4df29bf528679ff8b65f055baa2c4af3
Submitter: Jenkins
Branch: master

commit 66cad4ce4df29bf528679ff8b65f055baa2c4af3
Author: jichenjc <email address hidden>
Date: Thu Dec 4 15:35:57 2014 +0800

    Make service-list output consistent

    When libvirt automatic disable/enable services, the disabled
    reason will be 'None'. However, the column is Nullable and
    make it 'None' let the service-list output inconsistent.
    This patch changes the default value to NULL.

    Change-Id: I958accb500b4b417d755cff8df8ef7d615b710c0
    Closes-Bug: #1401480

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.