Very bad logline in IPA prints entire base64'd configdrive

Bug #1401244 reported by Jay Faulkner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Undecided
Jim Rollenhagen

Bug Description

https://github.com/openstack/ironic-python-agent/blob/master/ironic_python_agent/extensions/standby.py#L111

This should be logging the filename, not the configdrive contents as the configdrive contents are huge, base64'd, and ends up splitting over multiple loglines -- and is pretty useless.

tags: added: agent low-hanging-fruit
Changed in ironic:
assignee: nobody → Jay Faulkner (jason-oldos)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-python-agent (master)

Fix proposed to branch: master
Review: https://review.openstack.org/140830

Changed in ironic:
status: New → In Progress
Changed in ironic:
assignee: Jay Faulkner (jason-oldos) → Jim Rollenhagen (jim-rollenhagen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-python-agent (master)

Reviewed: https://review.openstack.org/140830
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=86d4b41709548cb304ab9cc0b627b39449eef121
Submitter: Jenkins
Branch: master

commit 86d4b41709548cb304ab9cc0b627b39449eef121
Author: Jay Faulkner <email address hidden>
Date: Wed Dec 10 12:12:34 2014 -0800

    Do not log configdrive contents ever

    Currently this logline contains the full, base64'd configdrive. This
    changes it to log the file it came from instead.

    Change-Id: I40fa4b8d889ce08fa20f7b0841b5abf122499676
    Closes-bug: 1401244

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.