'make help' in fuel-main/ starts file download instead of just printing help message

[Igor Zinovik]

Executing 'help' target does not work as expected. I've expected to see help message,
but instead make started download files. I think this behaviour is not expected.

% make --version
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
% git clone -q git://github.com/stackforge/fuel-main
% cd fuel-main
% make help
/home/zinovik/fuel-main/mirror/ubuntu/createchroot.mk:12: /home/zinovik/fuel-main/build/ubuntu_installer_kernel_version.mk: No such file
 or directory
/home/zinovik/fuel-main/upgrade/module.mk:210: warning: overriding commands for target `/home/zinovik/fuel-main/build/upgrade/openstack_
version_5.1'
/home/zinovik/fuel-main/upgrade/module.mk:210: warning: ignoring old commands for target `/home/zinovik/fuel-main/build/upgrade/openstac
k_version_5.1'
wget -nv -O /home/zinovik/fuel-main/local_mirror/ubuntu/installer-amd64/current/images/netboot/netboot.tar.gz.tmp http://mirror.fuel-inf
ra.org/fwm/6.1/ubuntu/installer-amd64/current/images/netboot/netboot.tar.gz
2014-12-10 16:22:06 URL:http://mirror.fuel-infra.org/fwm/6.1/ubuntu/installer-amd64/current/images/netboot/netboot.tar.gz [26064767/2606
4767] -> "/home/zinovik/fuel-main/local_mirror/ubuntu/installer-amd64/current/images/netboot/netboot.tar.gz.tmp" [1]
mv /home/zinovik/fuel-main/local_mirror/ubuntu/installer-amd64/current/images/netboot/netboot.tar.gz.tmp /home/zinovik/fuel-main/local_m
irror/ubuntu/installer-amd64/current/images/netboot/netboot.tar.gz
tar -xzf /home/zinovik/fuel-main/local_mirror/ubuntu/installer-amd64/current/images/netboot/netboot.tar.gz -C /home/zinovik/fuel-main/lo
cal_mirror/ubuntu/installer-amd64/current/images/netboot
100350 blocks
echo 'UBUNTU_INSTALLER_KERNEL_VERSION:=3.13.0-30-generic' > /home/zinovik/fuel-main/build/ubuntu_installer_kernel_version.mk
/home/zinovik/fuel-main/upgrade/module.mk:210: warning: overriding commands for target `/home/zinovik/fuel-main/build/upgrade/openstack_
version_5.1'
/home/zinovik/fuel-main/upgrade/module.mk:210: warning: ignoring old commands for target `/home/zinovik/fuel-main/build/upgrade/openstac
k_version_5.1'
Build directives (can be overrided by environment variables
or by command line parameters):
  SOURCE_DIR: /home/zinovik/fuel-main
  BUILD_DIR: /home/zinovik/fuel-main/build
  LOCAL_MIRROR: /home/zinovik/fuel-main/local_mirror
  YUM_REPOS: proprietary
  MIRROR_CENTOS: http://mirror.fuel-infra.org/fwm/6.1/centos
  EXTRA_RPM_REPOS:
  EXTRA_DEB_REPOS:
  ISO_DIR/ISO_NAME: /home/zinovik/fuel-main/build/artifacts/fuel-6.1.iso
  ENV_NAME:
  KSYAML: /home/zinovik/fuel-main/iso/ks.yamlz
...

This program built for x86_64-pc-linux-gnu

100% reproducable.

Steps to reproduce:
1. git clone git://github.com/stackforge/fuel-main
2. cd fuel-main
3. make help

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/140695

[Igor Gnatenko (i-gnatenko-brain)]

Thanks for reporting!

[Dmitry Pyzhov (dpyzhov)]

As I see, bug was introduced with change-id Ia8db615284644b0e2bcdb70c1c7bb1f4388d5e46 in 6.0 release. Later this piece of code was refactored and issue disappeared. So I suggest to abandon workaround for already fixed bug.

Possibly we could apply it to stable/6.0 branch. But it will produce difference between the branches and will add possibility for conflicts in future backports. So my proposal here is to set Won't Fix for stable/6.0 branch for this bug.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Roman Vyalov (<email address hidden>) on branch: master
Review: https://review.openstack.org/140695