OpenStack-Ansible

logstash: roles/logstash/templates/extras missing | for AUDITLOGLEVEL

Bug #1401091 reported by Jesse Pretorius
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Invalid
Low
Jesse Pretorius
Juno
Fix Released
Low
Jesse Pretorius
OpenStack-Ansible 10.1.2
Trunk
Invalid
Low
Jesse Pretorius

Bug Description

roles/logstash/templates/extras is missing a | after 'CRITICAL' resulting in the filter improperly processing CRITICAL or [A|a]udit log lines.

In fact, '[C|c]ritical|CRITICAL' is duplicated by the later [C|c]rit?(?:ical)?|CRIT?(?:ICAL)? so it can just be removed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/140666

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/140666
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=1ebd7e593924f8c04626764825a82289df2e1e96
Submitter: Jenkins
Branch: master

commit 1ebd7e593924f8c04626764825a82289df2e1e96
Author: Jesse Pretorius <email address hidden>
Date: Wed Dec 10 12:45:30 2014 +0000

    Remove redundant [C|c]ritical|CRITICAL pattern

    This patch removes '[C|c]ritical|CRITICAL' from the AUDITLOGLEVEL
    pattern as this pattern is more completely covered by the later
    '[C|c]rit?(?:ical)?|CRIT?(?:ICAL)?' pattern.

    This also removes a pattern bug as 'CRITICAL' should have been
    'CRITICAL|' anyway.

    Change-Id: I8c45ee13fb6b40e31bafa744f8fee5f4af7a90f5
    Closes-Bug: 1401091

Changed in openstack-ansible:
status: In Progress → Fix Committed
Kevin Carter (kevin-carter)
Changed in openstack-ansible:
milestone: 10.1.0 → 10.1.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (juno)

Fix proposed to branch: juno
Review: https://review.openstack.org/150377

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (juno)

Reviewed: https://review.openstack.org/150377
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=302e85effb6619e24d25388be5fbf11a5ce4dccf
Submitter: Jenkins
Branch: juno

commit 302e85effb6619e24d25388be5fbf11a5ce4dccf
Author: Jesse Pretorius <email address hidden>
Date: Wed Dec 10 12:45:30 2014 +0000

    Remove redundant [C|c]ritical|CRITICAL pattern

    This patch removes '[C|c]ritical|CRITICAL' from the AUDITLOGLEVEL
    pattern as this pattern is more completely covered by the later
    '[C|c]rit?(?:ical)?|CRIT?(?:ICAL)?' pattern.

    This also removes a pattern bug as 'CRITICAL' should have been
    'CRITICAL|' anyway.

    Change-Id: I8c45ee13fb6b40e31bafa744f8fee5f4af7a90f5
    Closes-Bug: 1401091
    (cherry picked from commit 1ebd7e593924f8c04626764825a82289df2e1e96)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.