vmware power manager doesn't tell power state correctly

[Arata Notsu]

Create a node with "ironic node-create -d pxe_ssh -i ssh_virt_type=vmware ..."
Then, try to create a new instance using the node. The node will be powered ON successfully. But soon, the provisioning will turn to ERROR. This is because the vmware power manager's list_running command cannot get the power state properly; it always says the power is OFF.

From a log like this, I found that the manager tried to get a state of the VM {_NodeName_}. But {_NodeName_} is a placeholder and has to be replaced with the actual target VM's ID.

2014-12-09 11:06:25.819 19357 DEBUG ironic.openstack.common.processutils [-] Running cmd (SSH): /bin/vim-cmd vmsvc/power.getstate {_NodeName_} | grep 'Powered on' >/dev/null && echo '"{_NodeName_}"' || true ssh_execute /usr/lib/python2.7/dist-packages/ironic/openstack/common/processutils.py:219

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/139810
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=af21ffd9867a175469ac1f11a394486b43abd519
Submitter: Jenkins
Branch: master

commit af21ffd9867a175469ac1f11a394486b43abd519
Author: Arata Notsu <email address hidden>
Date: Sun Dec 7 00:15:45 2014 +0900

    Correct vmware ssh power manager

    {_NodeName_} in list_running has to be replaced since the power manager
    relies on it.

    Now _get_hosts_name_for_node is called before list_running, so unit
    tests are modified too.

    Change-Id: I4a787039b7bc0f13c29455f041120e9e43e7c46b
    Closes-Bug: #1400674