Authentication failure results in useless error message

[Alex Gaynor]

If I provide insufficient credentials, the error message that is printed isn't very useful:

$ openstack --os-auth-type="password" --os-url="https://identity.api.rackspacecloud.com" --os-password='a' flavor list
ERROR: openstack

[Terry Howe (thowe-g)]

What version of cliff are you using there? There was a fix to cliff for this type of thing.

[Alex Gaynor (alex-gaynor)]

From `pip freeze`: cliff==1.9.0

[Steve Martinelli (stevemar)]

Confirmed with master, and no environment variables yet.
Alex, did this work for you before? Is it a regression?

[Steve Martinelli (stevemar)]

With --debug

steve:keystone$ openstack --os-auth-type="password" --os-url="https://identity.api.rackspacecloud.com" --os-password='a' user list --debug
DEBUG: cliff.commandmanager found command 'security_group_create'
DEBUG: cliff.commandmanager found command 'security_group_rule_list'
DEBUG: cliff.commandmanager found command 'keypair_list'
DEBUG: cliff.commandmanager found command 'keypair_delete'
DEBUG: cliff.commandmanager found command 'host_list'
DEBUG: cliff.commandmanager found command 'keypair_create'
DEBUG: cliff.commandmanager found command 'server_pause'
DEBUG: cliff.commandmanager found command 'server_reboot'
DEBUG: cliff.commandmanager found command 'server_migrate'
DEBUG: cliff.commandmanager found command 'server_set'
DEBUG: cliff.commandmanager found command 'host_show'
DEBUG: cliff.commandmanager found command 'server_unrescue'
DEBUG: cliff.commandmanager found command 'server_add_volume'
DEBUG: cliff.commandmanager found command 'server_unlock'
DEBUG: cliff.commandmanager found command 'security_group_set'
DEBUG: cliff.commandmanager found command 'compute_agent_create'
DEBUG: cliff.commandmanager found command 'server_rescue'
DEBUG: cliff.commandmanager found command 'server_add_security_group'
DEBUG: cliff.commandmanager found command 'console_log_show'
DEBUG: cliff.commandmanager found command 'compute_agent_delete'
DEBUG: cliff.commandmanager found command 'server_ssh'
DEBUG: cliff.commandmanager found command 'server_lock'
DEBUG: cliff.commandmanager found command 'server_unset'
DEBUG: cliff.commandmanager found command 'server_show'
DEBUG: cliff.commandmanager found command 'server_suspend'
DEBUG: cliff.commandmanager found command 'keypair_show'
DEBUG: cliff.commandmanager found command 'server_image_create'
DEBUG: cliff.commandmanager found command 'flavor_list'
DEBUG: cliff.commandmanager found command 'server_remove_volume'
DEBUG: cliff.commandmanager found command 'security_group_delete'
DEBUG: cliff.commandmanager found command 'aggregate_add_host'
DEBUG: cliff.commandmanager found command 'aggregate_remove_host'
DEBUG: cliff.commandmanager found command 'server_remove_security_group'
DEBUG: cliff.commandmanager found command 'ip_floating_remove'
DEBUG: cliff.commandmanager found command 'aggregate_create'
DEBUG: cliff.commandmanager found command 'hypervisor_show'
DEBUG: cliff.commandmanager found command 'ip_floating_list'
DEBUG: cliff.commandmanager found command 'aggregate_delete'
DEBUG: cliff.commandmanager found command 'security_group_rule_create'
DEBUG: cliff.commandmanager found command 'compute_agent_set'
DEBUG: cliff.commandmanager found command 'server_rebuild'
DEBUG: cliff.commandmanager found command 'flavor_delete'
DEBUG: cliff.commandmanager found command 'server_delete'
DEBUG: cliff.commandmanager found command 'server_resume'
DEBUG: cliff.commandmanager found command 'hypervisor_list'
DEBUG: cliff.commandmanager found command 'flavor_create'
DEBUG: cliff.commandmanager found command 'console_url_show'
DEBUG: cliff.commandmanager found command 'ip_fixed_add'
DEBUG: cliff.commandmanager found command 'server_create'
DEBUG: cliff.commandmanager found command 'aggregate_show'
DEBUG: cliff.command...

[Alex Gaynor (alex-gaynor)]

Not a regression (as far as I know) -- I hit this randomly messing around with the CLI today, I'm sure there's several errors in the parameters I've passed and god knows what else, all I'm asking for is a pretty error message :-)

[Steve Martinelli (stevemar)]

Just making notes here...

The minimum set of params needed for v2 password would be:
  --os-auth-url http://localhost:5000/v2.0
  --os-username admin
  --os-project-name admin

*note that if password is not provided, the user will be prompted for one*

We should check if --os-auth-type is password and then maybe do some light parameter checking for ensuring auth-url is set, and username, and project.

Doing a check for v3 password should be similar.

If --os-auth-type is set to token, then we should check for --os-url and --os-token.

We can provide our own custom error messages that are likely to be more helpful than what is currently being printed.

[Dean Troyer (dtroyer)]

I think it is the '#' in the bug message: implemented in https://review.openstack.org/#/c/147768/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/147768
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=fff4a1cd23057160af13f157a6fde2c172fae7a9
Submitter: Jenkins
Branch: master

commit fff4a1cd23057160af13f157a6fde2c172fae7a9
Author: Steve Martinelli <email address hidden>
Date: Fri Jan 16 02:20:52 2015 -0500

    Add helpful messages when authN'ing with password

    Setting up auth options can be complicated, and we currently don't
    do any checking before we build all our auth parameters to send off
    to keystoneclient. We should do some basic checking to guide new
    users.

    Change-Id: I9c88f1c9637b3870c151952ecc797aaf65be271a
    Closes-Bug: #1400531