should be upgraded to unittest2=>0.8.0

Bug #1400512 reported by Chris Gagnon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-unittest2 (Ubuntu)
New
Undecided
Unassigned

Bug Description

We need to upgrade python-testtools to version 1.5.0. This requires us to upgrade python-unittest2 to version => 0.8.0

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :
Revision history for this message
Daniel Holbach (dholbach) wrote :

The tarball contains no packaging (ie, a debian/ directory)... same with bug 1399223.

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

This has the debian folder and I fixed the unit2 (widows only) so we don't look for it.

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

My latest tarball has issues it only installs the documents folder :/

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

my latest tartball installs unittest2 and the docs yay!

Revision history for this message
Daniel Holbach (dholbach) wrote :

There's still no debian/ directory in the tarball?

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

sorry I messed that up. here is the tarball with the debian directory

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hey Chris! Thanks for the tarball and packaging. So far the changes look pretty sane and the package builds correctly. I have a few questions before uploading this - note that some might be obvious, but due to the fact that I'm not a maintainer of this package I need to ask those.

First thing: I noticed you removed two lines in the override_dh_auto_test part of debian/rules, and therefore it seems that no tests are now being ran during package build. We cannot allow to upload a new package to the archive with its tests disabled without any reason. Is there a reason for that to be happening here? I suppose the 0.8.0 version still has some unit tests.

The other smaller things:
- We would need to think about getting this to Debian as well
- Did you test that the new version does not break any of its reverse-dependencies? I saw a few packages build-depend on it, so I would feel safer actually if you made sure there's no API breakge here

Revision history for this message
Sebastien Bacher (seb128) wrote :

unsbuscribing sponsors until the review comment are address, please subscribe back then

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.