Deploy interface of IPA driver does not return required properties

[Yuriy Zveryanskyy]

Example:

A node with IPA driver:

user@ubuntu:~$ ironic node-show 208a64b7-7893-4cbe-8a60-79e2008f6de5
...
| driver_info | {} |
| extra | {} |
| last_error | None |
| created_at | 2014-12-08T14:00:42+00:00 |
| target_provision_state | None |
| driver | agent_ipmitool |
...
+------------------------+--------------------------------------+

Driver properties, only IPMI listed:
user@ubuntu:~$ ironic driver-properties agent_ipmitool
+----------------------+-------------------------------------------------------------------------------------------------------------+
| Property | Description |
+----------------------+-------------------------------------------------------------------------------------------------------------+
| ipmi_address | IP address or hostname of the node. Required. |
| ipmi_bridging | bridging_type; default is "no". One of "single", "dual", "no". Optional. |
| ipmi_local_address | local IPMB address for bridged requests. Used only if ipmi_bridging is set to "single" or "dual". Optional. |
| ipmi_password | password. Optional. |
| ipmi_priv_level | privilege level; default is ADMINISTRATOR. One of ADMINISTRATOR, CALLBACK, OPERATOR, USER. Optional. |
| ipmi_target_address | destination address for bridged request. Required only if ipmi_bridging is set to "single" or "dual". |
| ipmi_target_channel | destination channel for bridged request. Required only if ipmi_bridging is set to "single" or "dual". |
| ipmi_terminal_port | node's UDP port to connect to. Only required for console access. |
| ipmi_transit_address | transit address for bridged request. Required only if ipmi_bridging is set to "dual". |
| ipmi_transit_channel | transit channel for bridged request. Required only if ipmi_bridging is set to "dual". |
| ipmi_username | username; default is NULL user. Optional. |
+----------------------+-------------------------------------------------------------------------------------------------------------+

Validation:
user@ubuntu:~$ ironic node-validate 208a64b7-7893-4cbe-8a60-79e2008f6de5
+------------+--------+---------------------------------------------------------------------------------+
| Interface | Result | Reason |
+------------+--------+---------------------------------------------------------------------------------+
| console | False | Missing the following IPMI credentials in node's driver_info: ['ipmi_address']. |
| deploy | False | Node 208a64b7-7893-4cbe-8a60-79e2008f6de5 failed to validate deploy image info | <-Missing required
| management | False | Missing the following IPMI credentials in node's driver_info: ['ipmi_address']. |
| power | False | Missing the following IPMI credentials in node's driver_info: ['ipmi_address']. |
+------------+--------+---------------------------------------------------------------------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/158313

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/158313
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c991bb2c846690bd360ab22ed678b7d99a38f7cc
Submitter: Jenkins
Branch: master

commit c991bb2c846690bd360ab22ed678b7d99a38f7cc
Author: Yuriy Zveryanskyy <email address hidden>
Date: Mon Feb 23 15:57:56 2015 +0200

    Return required properties for agent deploy driver

    IPA deploy driver does not return required properties, this
    patch adds this properties.

    Closes-Bug: 1400342
    Change-Id: I19172e957f2601d7d20a53fef1079ad421a6e893