Metering label rule creation improvements

Bug #1400280 reported by Ilya N. Sokolov
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Ilya N. Sokolov

Bug Description

When neutron user create metering label rule neutron-api fetches all labels from database, sends it to the queue, metering agent reads it and recreate all chains in iptables.
It's not optimal and cause high load of neutron if you use labels/rules.

I think we can send only new rule and add this rule in iptables chain.

Tags: metering
Revision history for this message
George Shuklin (george-shuklin) wrote :

I think this is somehow related to https://bugs.launchpad.net/neutron/+bug/1396677. It looks like same pattern: request all data from DB, than parse. I think it is not really scalable and production-oriented.

description: updated
tags: removed: iptables
Changed in neutron:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Eugene Nikanorov (enikanorov) wrote :

I don't think a blueprint is needed for such kind of improvement.

description: updated
oleksii (oleksii-shyman)
Changed in neutron:
assignee: nobody → oleksii (oleksii-shyman)
Revision history for this message
Ilya N. Sokolov (falconmain) wrote :

Oh. I already start to fix it in my stand.
Can you please reassign it to me?

Revision history for this message
oleksii (oleksii-shyman) wrote :

go ahead, assign yourself!

Changed in neutron:
assignee: oleksii (oleksii-shyman) → nobody
Changed in neutron:
assignee: nobody → Ilya N. Sokolov (falconmain)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143672

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
Ilya N. Sokolov (falconmain) wrote :

So, i pushed the changes.
But i'm not sure about format of queue message.

Edgar Magana (emagana)
Changed in neutron:
milestone: none → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/143672
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6abc6399df4903881a1ee292be9f721e0252c529
Submitter: Jenkins
Branch: master

commit 6abc6399df4903881a1ee292be9f721e0252c529
Author: Ilya Sokolov <email address hidden>
Date: Tue Dec 23 13:22:20 2014 +0000

    Send only one rule in queue on rule create/delete

    Now we send all labels and rules per rule create/delete
    and rebuild whole iptables chains.
    In this patch we send only affected rule and create/
    delete only this rule from iptables.

    Change-Id: I58ebd8d810c62980c09a340ee1680be17c12b74a
    Closes-Bug: #1400280

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-rc1 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (neutron-pecan)

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.