network resources are not released after failed share server creation

[Valeriy Ponomaryov]

If we try to create share with backend that uses share-server, its network resources won't be released indeed, but expected.

method "deallocate_network" of module "neutron_network_plugin" expects "share_server" as second param, see:

https://github.com/openstack/manila/blob/2023930f/manila/network/neutron/neutron_network_plugin.py#L67

but manager provides "share_network" and DB does not complain, it just returns empty list. See:

https://github.com/openstack/manila/blob/2023930f/manila/share/manager.py#L481

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/139690

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/139690
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=8b083605fbe0aa4e70e900e76520784c39c06515
Submitter: Jenkins
Branch: master

commit 8b083605fbe0aa4e70e900e76520784c39c06515
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Dec 5 19:34:11 2014 +0200

    Release network resources properly

    If we try to create share with backend that uses share-server,
    its network resources won't be released because of improper param provided.
    Method "deallocate_network" of module "neutron_network_plugin" expects
    "share_server" as second param but "share_network" is provided indeed.

    Make it be called only when share_server deleted and errored after network
    resources provided and with proper params.

    Change-Id: I8f79724dacb3dd7efc75dc459529a0c3185f999f
    Closes-Bug: #1399732