Crash if EA -> SA algorithm order is used

[ariel]

User reports:

We use "Mont Blanc" - Geneva 1.2.
If EA -> SA algorithm order is used, SA-algorithm throws exception in runFitnessCalculation()-Function due to set dirty flag.
i.e. GSerialSA::runFitnessCalculation(), line 256

The DEBUG-Macro is defined.

SA -> EA order works fine.
EA -> GD, SA -> GD as well

[Ruediger Berlich (rberlich)]

Confirmed for the current trunk version, using 02_GSimpleParabola. go & "sa" & "ea" & "sa"; crashes after "ea" with message:

End of optimization reached in algorithm "Evolutionary Algorithm"
Starting an optimization run with algorithm "Simulated Annealing"
terminate called after throwing an instance of 'Gem::Common::gemfony_error_condition'
  what():
================================================
ERROR (recorded on 2014-Dec-06 19:36:01)
in file /home/rberlich/Progs/Geneva/src/geneva/GMultiThreadedSA.cpp near line 265

In GMultiThreadedSA::runFitnessCalculation(): Error!
Tried to evaluate "clean" children.

If you suspect that this error is due to Geneva,
then please consider filing a bug via
http://www.gemfony.eu (link "Bug Reports") or
through http://www.launchpad.net/geneva

We appreciate your help!
The Geneva team
================================================

Thanks for catching this.

[Ruediger Berlich (rberlich)]

When individuals are handed from one algorithm to the other, they may be clean. This was taken care of in EA, but not in SA.

[Ruediger Berlich (rberlich)]

I believe this is fixed now. SA is really just a special kind of EA, we follow the same strategy in SA now.